fix: Updates dynamic tables query parsing to correctly handle tables that include "as" in their name (#2329) #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that include "as" in their name (Snowflake-Labs#2329)
|
Hey. It wouldn't work, e.g. because you can have " AS " as a part of the comment. Also, the cut number was not adjusted (3 -> 5). I am closing it and following up on it in #2421 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Index in the query parsing is too greedy and grabs any string with the letter "as" in them. If a table has "as" then the query is never a match and the dynamic is recreated in every terraform plan.
Test Plan
I have not tested locally since I'm not comfortable running acceptance tests against our live snowflake account. Creating a draft PR in hopes that CI will run tests and you all can review and verify the change.
References
Attempts to fix #2329