fix: Add secondary account and fix tests #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for bd1937753f303ecb0b95e6d48533f5c3bff785eb |
sfc-gh-asawicki
requested changes
Jan 8, 2024
|
Integration tests failure for 226f3172050d363d97f9ab1619fbc52d2e3b084a |
sfc-gh-jcieslak
force-pushed
the
add-tests-with-second-account
branch
from
226f317 to
699a230
Compare
|
Integration tests failure for 699a230e8c5d296c733adf809f5e014c86223bb7 |
sfc-gh-jcieslak
force-pushed
the
add-tests-with-second-account
branch
from
beb3a4d to
033b7bb
Compare
|
Integration tests failure for beb3a4df6bf1289fb574326ca1aaa3dadcaade1e |
|
Integration tests failure for 033b7bb2d715130448f04656162cf0b89d489ed6 |
sfc-gh-asawicki
previously approved these changes
Jan 9, 2024
|
Integration tests failure for 7220388583de46b00f0ab5eb0d8c3385f7f928c7 |
sfc-gh-swinkler
approved these changes
Jan 9, 2024
sfc-gh-jcieslak
force-pushed
the
add-tests-with-second-account
branch
from
7220388 to
f60d8de
Compare
|
Integration tests failure for f60d8deea71808b5324c26174f2f2e3fc8dd8cf9 |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.83.0](v0.82.0...v0.83.0) (2024-01-11) ### 🎉 **What's new:** * Add create streamlit privilege to the SDK ([#2303](#2303)) ([be01d5f](be01d5f)) * grant privileges to database role resource ([#2306](#2306)) ([0311cf8](0311cf8)) ### 🐛 **Bug fixes:** * Add secondary account and fix tests ([#2324](#2324)) ([da6ca73](da6ca73)) * external tables issues ([#2334](#2334)) ([ae41691](ae41691)) * Fix test because of the date ([#2312](#2312)) ([9a9ea33](9a9ea33)) * Fix warehouse read and resource monitor empty set ([#2319](#2319)) ([05f96c6](05f96c6)), closes [#2318](#2318) [#2316](#2316) * goreleaser for mfa token caching ([#2320](#2320)) ([4fef709](4fef709)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secondary account was added + tests with shares were fixed.
It turned out that the secondary has different business criticality (they probably should have the same business criticality). But for now, it only means I had to swap accounts in some places because you cannot share something from lower to higher business critically account (or vice-verse didn't remember).