Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grant role resource #2304

Merged
merged 7 commits into from
Jan 18, 2024
Merged

feat: add grant role resource #2304

merged 7 commits into from
Jan 18, 2024

Conversation

sfc-gh-swinkler
Copy link
Collaborator

adds snowflake_grant_role resource. Should this be renamed to snowflake_grant_account_role instead?
https://docs.snowflake.com/en/sql-reference/sql/grant-role

Copy link

Integration tests failure for eb6d1db390ddf5d97b5ad9f8984be926d93cf4e4

@sfc-gh-asawicki
Copy link
Collaborator

adds snowflake_grant_role resource. Should this be renamed to snowflake_grant_account_role instead? https://docs.snowflake.com/en/sql-reference/sql/grant-role

I think this is a valid idea. We have *_role for every other planned resource. @sfc-gh-jcieslak wdyt?

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 4, 2024 09:45
pkg/resources/grant_role.go Outdated Show resolved Hide resolved
pkg/resources/grant_role.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for 49da10a2698dba25bd859248ca79e5db9506b3d2

Copy link

Integration tests failure for 4985f163a18536cb0429e4d08a1a8ba864c61030

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 17, 2024 10:22
Copy link

Integration tests failure for e5fbb0ace296484d188075a6e7c115ff847b0895

Copy link

Integration tests failure for 5e7669d9251be9723543013fdbb3d69fab4993d6

@sfc-gh-swinkler sfc-gh-swinkler merged commit ba91e25 into main Jan 18, 2024
5 of 7 checks passed
@sfc-gh-swinkler sfc-gh-swinkler deleted the role-grant branch January 18, 2024 07:31
Copy link

Integration tests failure for 9bb74156046fc6ccde08b6240f322e3c9c564809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants