Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix some bugs #2234

Merged
merged 9 commits into from
Dec 8, 2023
Merged

fix: Fix some bugs #2234

merged 9 commits into from
Dec 8, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Dec 6, 2023

Introduce some fixes:

  • fix database dropped outside Terraform behavior
  • fix alert datasource
  • fix dynamic table datasource filtering

Fix #2216
Fix #2217

Copy link

github-actions bot commented Dec 6, 2023

Integration tests failure for f2d82028bd4941b67babf0fb5cd5cb1ed0af43d3

Copy link

github-actions bot commented Dec 6, 2023

Integration tests success for f2d82028bd4941b67babf0fb5cd5cb1ed0af43d3

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review December 6, 2023 15:22
Copy link

github-actions bot commented Dec 7, 2023

Integration tests failure for 5f8ab2c7c8b70ef2b89ab491647e192730eec2b3

sfc-gh-jcieslak
sfc-gh-jcieslak previously approved these changes Dec 7, 2023
pkg/datasources/alerts_acceptance_test.go Show resolved Hide resolved
Copy link

github-actions bot commented Dec 7, 2023

Integration tests failure for 5f8ab2c7c8b70ef2b89ab491647e192730eec2b3

sfc-gh-swinkler
sfc-gh-swinkler previously approved these changes Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Integration tests failure for e2d304ee41fc0daf84787869f2a0ffae001f06e9

Copy link

github-actions bot commented Dec 8, 2023

Integration tests success for 98eab8e3400d04ce3489ea5f7105b66b9905786d

@sfc-gh-asawicki sfc-gh-asawicki merged commit 774a7db into main Dec 8, 2023
8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-some-bugs branch December 8, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants