feat: Introduce simple arch tests #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for dd5e885f30e62cdc3e7a405cdd243ad1dee32bdf |
|
Integration tests failure for a68b35de3f7c29f8b74f32773584f4d71e4c0d83 |
2 similar comments
|
Integration tests failure for a68b35de3f7c29f8b74f32773584f4d71e4c0d83 |
|
Integration tests failure for a68b35de3f7c29f8b74f32773584f4d71e4c0d83 |
|
Integration tests failure for 176a61950552f12cf58dd0a165223079cfb6f7b7 |
sfc-gh-jcieslak
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a simple way to write tests asserting our architecture composition. Inspired by https://www.archunit.org/.
A quick search did not result in finding any existing libs allowing us to assert our specific use case (existing libs were mostly about asserting dependencies between packages; we wanted to check if the tests in the package are named correctly, i.e.
TestAcc_for acceptance tests).This tool may be extended later or even extracted from this repository.
Important parts of the change:
architestsdirectory - checking the acceptance and integration test namesarchitestdirectorysdkpackage was the result of the tests runI also encourage to test locally how it behaves when you try to provide e.g. bad test name.