feat: add functions to sdk #2205

sfc-gh-swinkler · 2023-11-22T07:49:18Z

add functions to SDK v2
https://docs.snowflake.com/en/sql-reference/sql/create-function

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

staticcheck

pkg/sdk/functions_impl_gen.go|257 col 13| should convert v (type FunctionColumnRequest) to FunctionColumn instead of using struct literal
pkg/sdk/functions_impl_gen.go|278 col 11| should convert v (type FunctionImportsRequest) to FunctionImports instead of using struct literal
pkg/sdk/functions_impl_gen.go|287 col 11| should convert v (type FunctionPackagesRequest) to FunctionPackages instead of using struct literal
pkg/sdk/functions_impl_gen.go|296 col 11| should convert v (type FunctionSecretRequest) to FunctionSecret instead of using struct literal
pkg/sdk/functions_impl_gen.go|328 col 11| should convert v (type FunctionArgumentRequest) to FunctionArgument instead of using struct literal
pkg/sdk/functions_impl_gen.go|344 col 13| should convert v (type FunctionColumnRequest) to FunctionColumn instead of using struct literal
pkg/sdk/functions_impl_gen.go|365 col 11| should convert v (type FunctionImportsRequest) to FunctionImports instead of using struct literal
pkg/sdk/functions_impl_gen.go|374 col 11| should convert v (type FunctionPackagesRequest) to FunctionPackages instead of using struct literal
pkg/sdk/functions_impl_gen.go|402 col 11| should convert v (type FunctionArgumentRequest) to FunctionArgument instead of using struct literal
pkg/sdk/functions_impl_gen.go|418 col 13| should convert v (type FunctionColumnRequest) to FunctionColumn instead of using struct literal
pkg/sdk/functions_impl_gen.go|451 col 11| should convert v (type FunctionArgumentTypeRequest) to FunctionArgumentType instead of using struct literal
pkg/sdk/functions_impl_gen.go|484 col 11| should convert v (type FunctionArgumentTypeRequest) to FunctionArgumentType instead of using struct literal
pkg/sdk/functions_impl_gen.go|501 col 22| func functionRow.convert is unused
pkg/sdk/functions_impl_gen.go|524 col 11| should convert v (type FunctionArgumentTypeRequest) to FunctionArgumentType instead of using struct literal
pkg/sdk/functions_impl_gen.go|533 col 28| func functionDetailRow.convert is unused

github-actions · 2023-11-22T07:51:05Z

pkg/sdk/functions_gen.go

+
+// CreateFunctionForJavaFunctionOptions is based on https://docs.snowflake.com/en/sql-reference/sql/create-function.
+type CreateFunctionForJavaFunctionOptions struct {
+	create                     bool                           `ddl:"static" sql:"CREATE"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field create is unused

github-actions · 2023-11-22T07:51:05Z

pkg/sdk/functions_gen.go

+	OrReplace                  *bool                          `ddl:"keyword" sql:"OR REPLACE"`
+	Temporary                  *bool                          `ddl:"keyword" sql:"TEMPORARY"`
+	Secure                     *bool                          `ddl:"keyword" sql:"SECURE"`
+	function                   bool                           `ddl:"static" sql:"FUNCTION"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field function is unused

github-actions · 2023-11-22T07:51:05Z

pkg/sdk/functions_gen.go

+	CopyGrants                 *bool                          `ddl:"keyword" sql:"COPY GRANTS"`
+	Returns                    *FunctionReturns               `ddl:"keyword" sql:"RETURNS"`
+	ReturnNullValues           *FunctionReturnNullValues      `ddl:"keyword"`
+	languageJava               bool                           `ddl:"static" sql:"LANGUAGE JAVA"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field languageJava is unused

github-actions · 2023-11-22T07:51:05Z

pkg/sdk/functions_gen.go

+
+// CreateFunctionForJavascriptFunctionOptions is based on https://docs.snowflake.com/en/sql-reference/sql/create-function.
+type CreateFunctionForJavascriptFunctionOptions struct {
+	create                bool                           `ddl:"static" sql:"CREATE"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field create is unused

github-actions · 2023-11-22T07:51:05Z

pkg/sdk/functions_gen.go

+	OrReplace             *bool                          `ddl:"keyword" sql:"OR REPLACE"`
+	Temporary             *bool                          `ddl:"keyword" sql:"TEMPORARY"`
+	Secure                *bool                          `ddl:"keyword" sql:"SECURE"`
+	function              bool                           `ddl:"static" sql:"FUNCTION"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field function is unused

github-actions · 2023-11-22T07:51:07Z

pkg/sdk/functions_impl_gen.go

+	if r.Packages != nil {
+		s := make([]FunctionPackages, len(r.Packages))
+		for i, v := range r.Packages {
+			s[i] = FunctionPackages{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionPackagesRequest) to FunctionPackages instead of using struct literal

github-actions · 2023-11-22T07:51:07Z

pkg/sdk/functions_impl_gen.go

+	if r.Secrets != nil {
+		s := make([]FunctionSecret, len(r.Secrets))
+		for i, v := range r.Secrets {
+			s[i] = FunctionSecret{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionSecretRequest) to FunctionSecret instead of using struct literal

github-actions · 2023-11-22T07:51:07Z

pkg/sdk/functions_impl_gen.go

+	if r.Arguments != nil {
+		s := make([]FunctionArgument, len(r.Arguments))
+		for i, v := range r.Arguments {
+			s[i] = FunctionArgument{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionArgumentRequest) to FunctionArgument instead of using struct literal

github-actions · 2023-11-22T07:51:07Z

pkg/sdk/functions_impl_gen.go

+			if r.Returns.Table.Columns != nil {
+				s := make([]FunctionColumn, len(r.Returns.Table.Columns))
+				for i, v := range r.Returns.Table.Columns {
+					s[i] = FunctionColumn{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionColumnRequest) to FunctionColumn instead of using struct literal

github-actions · 2023-11-22T07:51:07Z

pkg/sdk/functions_impl_gen.go

+	if r.Arguments != nil {
+		s := make([]FunctionArgument, len(r.Arguments))
+		for i, v := range r.Arguments {
+			s[i] = FunctionArgument{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionArgumentRequest) to FunctionArgument instead of using struct literal

pkg/sdk/functions_def.go

pkg/sdk/testint/functions_integration_test.go

pkg/sdk/functions_def.go

github-actions · 2023-11-27T05:07:48Z

pkg/sdk/functions_impl_gen.go

+			if r.Returns.Table.Columns != nil {
+				s := make([]FunctionColumn, len(r.Returns.Table.Columns))
+				for i, v := range r.Returns.Table.Columns {
+					s[i] = FunctionColumn{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionColumnRequest) to FunctionColumn instead of using struct literal

github-actions · 2023-11-27T05:07:48Z

pkg/sdk/functions_impl_gen.go

+	if r.Imports != nil {
+		s := make([]FunctionImports, len(r.Imports))
+		for i, v := range r.Imports {
+			s[i] = FunctionImports{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionImportsRequest) to FunctionImports instead of using struct literal

github-actions · 2023-11-27T05:07:48Z

pkg/sdk/functions_impl_gen.go

+	if r.Packages != nil {
+		s := make([]FunctionPackages, len(r.Packages))
+		for i, v := range r.Packages {
+			s[i] = FunctionPackages{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionPackagesRequest) to FunctionPackages instead of using struct literal

github-actions · 2023-11-27T05:07:49Z

pkg/sdk/functions_impl_gen.go

+	if r.Secrets != nil {
+		s := make([]FunctionSecret, len(r.Secrets))
+		for i, v := range r.Secrets {
+			s[i] = FunctionSecret{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionSecretRequest) to FunctionSecret instead of using struct literal

github-actions · 2023-11-27T05:07:49Z

pkg/sdk/functions_impl_gen.go

+	if r.Arguments != nil {
+		s := make([]FunctionArgument, len(r.Arguments))
+		for i, v := range r.Arguments {
+			s[i] = FunctionArgument{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionArgumentRequest) to FunctionArgument instead of using struct literal

github-actions · 2023-11-27T05:07:49Z

pkg/sdk/functions_impl_gen.go

+	if r.ArgumentTypes != nil {
+		s := make([]FunctionArgumentType, len(r.ArgumentTypes))
+		for i, v := range r.ArgumentTypes {
+			s[i] = FunctionArgumentType{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionArgumentTypeRequest) to FunctionArgumentType instead of using struct literal

github-actions · 2023-11-27T05:07:49Z

pkg/sdk/functions_impl_gen.go

+	if r.ArgumentTypes != nil {
+		s := make([]FunctionArgumentType, len(r.ArgumentTypes))
+		for i, v := range r.ArgumentTypes {
+			s[i] = FunctionArgumentType{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionArgumentTypeRequest) to FunctionArgumentType instead of using struct literal

github-actions · 2023-11-27T05:07:49Z

pkg/sdk/functions_impl_gen.go

+	return opts
+}
+
+func (r functionRow) convert() *Function {


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
func functionRow.convert is unused

github-actions · 2023-11-27T05:07:50Z

pkg/sdk/functions_impl_gen.go

+	if r.ArgumentTypes != nil {
+		s := make([]FunctionArgumentType, len(r.ArgumentTypes))
+		for i, v := range r.ArgumentTypes {
+			s[i] = FunctionArgumentType{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type FunctionArgumentTypeRequest) to FunctionArgumentType instead of using struct literal

github-actions · 2023-11-27T05:07:50Z

pkg/sdk/functions_impl_gen.go

+	return opts
+}
+
+func (r functionDetailRow) convert() *FunctionDetail {


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
func functionDetailRow.convert is unused

github-actions · 2023-11-27T05:14:57Z

Integration tests failure for fc6b2e02e7b2434d3dc7754c4965551484516dc8

github-actions · 2023-12-05T07:30:11Z

Integration tests failure for 17ef49f54533d3cbd08bf2147ba5f4c8eecb7a07

github-actions · 2023-12-05T07:31:01Z

Integration tests failure for c7fbc465faf91a2e999a9b0f1bee135b99637c16

pkg/sdk/functions_validations_gen.go

…raform-provider-snowflake into functions-sdk

github-actions · 2023-12-07T07:55:59Z

Integration tests failure for a121f435d85c3de5651fca7301e5bfc9d4fd7b40

github-actions · 2023-12-07T08:13:22Z

Integration tests failure for 6f9c4a5d97570b431d1eb78f34cf83c5deb062d0

sfc-gh-jcieslak

Hey, just leave a comment I've asked for in #2205 (comment) and other than that it's 👍

🥇

pkg/sdk/functions_gen_test.go

…raform-provider-snowflake into functions-sdk

github-actions · 2023-12-08T08:19:01Z

Integration tests failure for 364ce2e4eb27758ef50923f1b5386925d5ccc65c

github-actions · 2023-12-09T01:26:57Z

Integration tests success for 7cb75f8c3d2be22d22b7c4d32446ff020c96add4

…raform-provider-snowflake into functions-sdk

github-actions · 2023-12-18T10:14:53Z

Integration tests failure for d532974bf351c3613ca5034154f19187c4e24cc3

github-actions · 2023-12-18T10:22:52Z

Integration tests failure for 11d8d82d33d997d8a9a2a4c15ef94d2765bbf803

github-actions · 2023-12-18T12:05:59Z

Integration tests failure for 2e6c0e9f20e7faff3ade26d6c46012df7f42b0bf

github-actions · 2023-12-20T08:20:55Z

Integration tests failure for a5436b0cb951f8b7c65ce1ac3ad65a458351b1f9

github-actions · 2023-12-20T08:27:11Z

Integration tests failure for 3af6f874fdf0fedd1ff2816b3c4fc3d2f68f2836

…raform-provider-snowflake into functions-sdk

github-actions · 2023-12-21T06:57:10Z

Integration tests failure for a7fd45b0864c1b3231d92b2150485976d8f83110

github-actions · 2023-12-21T07:13:05Z

Integration tests failure for 53acfd5c87099c8e334ff80d0705f385eaf037d0

🤖 I have created a release *beep* *boop* --- ## [0.82.0](v0.81.0...v0.82.0) (2023-12-21) ### 🎉 **What's new:** * add functions to sdk ([#2205](#2205)) ([e542b67](e542b67)) ### 🔧 **Misc** * Add short scripts used to fetch all currently opened issues ([#2288](#2288)) ([0b5ce4e](0b5ce4e)) * Bump dependencies and fix linter complaints ([#2300](#2300)) ([124e862](124e862)) ### 🐛 **Bug fixes:** * Fix resource monitor alter validations in the SDK ([#2298](#2298)) ([74d19d0](74d19d0)) * Fix email notification integration ([#2292](#2292)) ([70edd3e](70edd3e)) * Fix for #2283 ([#2284](#2284)) ([bbad5c6](bbad5c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

add functions to sdk

5a72736

github-actions bot reviewed Nov 22, 2023

View reviewed changes

sfc-gh-jcieslak requested changes Nov 22, 2023

View reviewed changes

sfc-gh-jcieslak reviewed Nov 22, 2023

View reviewed changes

pkg/sdk/functions_def.go Outdated Show resolved Hide resolved

update

fc6b2e0

github-actions bot reviewed Nov 27, 2023

View reviewed changes

sfc-gh-swinkler added 2 commits December 4, 2023 23:01

update functions

17ef49f

Merge branch 'main' into functions-sdk

c7fbc46

sfc-gh-jcieslak reviewed Dec 5, 2023

View reviewed changes

pkg/sdk/functions_validations_gen.go Outdated Show resolved Hide resolved

sfc-gh-jcieslak reviewed Dec 5, 2023

View reviewed changes

pkg/sdk/functions_validations_gen.go Show resolved Hide resolved

sfc-gh-swinkler added 3 commits December 6, 2023 23:35

update error func

7d9ca23

Merge branch 'functions-sdk' of https://github.com/Snowflake-Labs/ter…

a121f43

…raform-provider-snowflake into functions-sdk

Merge branch 'main' into functions-sdk

6f9c4a5

sfc-gh-jcieslak previously approved these changes Dec 7, 2023

View reviewed changes

sfc-gh-asawicki requested changes Dec 7, 2023

View reviewed changes

sfc-gh-swinkler added 2 commits December 7, 2023 23:41

add todo

641b0b8

Merge branch 'functions-sdk' of https://github.com/Snowflake-Labs/ter…

3ad3e24

…raform-provider-snowflake into functions-sdk

sfc-gh-swinkler dismissed sfc-gh-jcieslak’s stale review via 3ad3e24 December 8, 2023 07:41

add todo

f1757e4

Snowflake-Labs deleted a comment from scottwinkler Dec 8, 2023

Merge branch 'main' into functions-sdk

364ce2e

sfc-gh-asawicki self-requested a review December 8, 2023 14:28

Merge branch 'main' into functions-sdk

7cb75f8

sfc-gh-swinkler added 3 commits December 18, 2023 01:53

update

571486b

Merge branch 'functions-sdk' of https://github.com/Snowflake-Labs/ter…

d532974

…raform-provider-snowflake into functions-sdk

Merge branch 'main' into functions-sdk

11d8d82

fmt

2e6c0e9

sfc-gh-swinkler added 2 commits December 19, 2023 23:52

add validations

a5436b0

Merge branch 'main' into functions-sdk

3af6f87

sfc-gh-swinkler added 3 commits December 20, 2023 22:28

add unit tests for desc

c7462cb

Merge branch 'functions-sdk' of https://github.com/Snowflake-Labs/ter…

a7fd45b

…raform-provider-snowflake into functions-sdk

Merge branch 'main' into functions-sdk

53acfd5

sfc-gh-asawicki approved these changes Dec 21, 2023

View reviewed changes

sfc-gh-jcieslak approved these changes Dec 21, 2023

View reviewed changes

sfc-gh-asawicki merged commit e542b67 into main Dec 21, 2023
6 of 8 checks passed

sfc-gh-asawicki deleted the functions-sdk branch December 21, 2023 10:24

snowflake-release-please bot mentioned this pull request Dec 21, 2023

chore(main): release 0.82.0 #2297

Merged

feat: add functions to sdk #2205

feat: add functions to sdk #2205

Conversation

sfc-gh-swinkler commented Nov 22, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot Nov 27, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

sfc-gh-jcieslak left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 9, 2023

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023