feat: add procedures to sdkv2 #2202

sfc-gh-swinkler · 2023-11-21T05:48:35Z

Adds procedures to sdk.

https://docs.snowflake.com/en/sql-reference/sql/create-procedure

github-actions · 2023-11-21T05:50:25Z

pkg/sdk/procedures_impl_gen.go

+	if r.Arguments != nil {
+		s := make([]ProcedureArgument, len(r.Arguments))
+		for i, v := range r.Arguments {
+			s[i] = ProcedureArgument{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureArgumentRequest) to ProcedureArgument instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:26Z

pkg/sdk/procedures_impl_gen.go

+			if r.Returns.Table.Columns != nil {
+				s := make([]ProcedureColumn, len(r.Returns.Table.Columns))
+				for i, v := range r.Returns.Table.Columns {
+					s[i] = ProcedureColumn{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureColumnRequest) to ProcedureColumn instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:26Z

pkg/sdk/procedures_impl_gen.go

+	if r.Packages != nil {
+		s := make([]ProcedurePackage, len(r.Packages))
+		for i, v := range r.Packages {
+			s[i] = ProcedurePackage{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedurePackageRequest) to ProcedurePackage instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:26Z

pkg/sdk/procedures_impl_gen.go

+	if r.Imports != nil {
+		s := make([]ProcedureImport, len(r.Imports))
+		for i, v := range r.Imports {
+			s[i] = ProcedureImport{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureImportRequest) to ProcedureImport instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:26Z

pkg/sdk/procedures_impl_gen.go

+	if r.Secrets != nil {
+		s := make([]ProcedureSecret, len(r.Secrets))
+		for i, v := range r.Secrets {
+			s[i] = ProcedureSecret{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureSecretRequest) to ProcedureSecret instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:26Z

pkg/sdk/procedures_impl_gen.go

+	if r.Packages != nil {
+		s := make([]ProcedurePackage, len(r.Packages))
+		for i, v := range r.Packages {
+			s[i] = ProcedurePackage{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedurePackageRequest) to ProcedurePackage instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:26Z

pkg/sdk/procedures_impl_gen.go

+	if r.Imports != nil {
+		s := make([]ProcedureImport, len(r.Imports))
+		for i, v := range r.Imports {
+			s[i] = ProcedureImport{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureImportRequest) to ProcedureImport instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:27Z

pkg/sdk/procedures_impl_gen.go

+	if r.ArgumentTypes != nil {
+		s := make([]ProcedureArgumentType, len(r.ArgumentTypes))
+		for i, v := range r.ArgumentTypes {
+			s[i] = ProcedureArgumentType{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureArgumentTypeRequest) to ProcedureArgumentType instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:27Z

pkg/sdk/procedures_impl_gen.go

+	if r.ArgumentTypes != nil {
+		s := make([]ProcedureArgumentType, len(r.ArgumentTypes))
+		for i, v := range r.ArgumentTypes {
+			s[i] = ProcedureArgumentType{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureArgumentTypeRequest) to ProcedureArgumentType instead of using struct literal (gosimple)

github-actions · 2023-11-21T05:50:27Z

pkg/sdk/procedures_impl_gen.go

+	if r.ArgumentTypes != nil {
+		s := make([]ProcedureArgumentType, len(r.ArgumentTypes))
+		for i, v := range r.ArgumentTypes {
+			s[i] = ProcedureArgumentType{


🚫 [golangci] _{reported by reviewdog 🐶}
S1016: should convert v (type ProcedureArgumentTypeRequest) to ProcedureArgumentType instead of using struct literal (gosimple)

github-actions · 2023-11-21T06:07:16Z

Integration tests failure for 5dba820e79e671d17f8a671fecf14e2d23740b96

pkg/sdk/procedures_def.go

pkg/sdk/procedures_gen.go

pkg/sdk/procedures_def.go

pkg/sdk/procedures_gen.go

pkg/sdk/procedures_impl_gen.go

pkg/sdk/testint/procedures_integration_test.go

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

staticcheck

pkg/sdk/procedures_impl_gen.go|237 col 13| should convert v (type ProcedureColumnRequest) to ProcedureColumn instead of using struct literal
pkg/sdk/procedures_impl_gen.go|249 col 11| should convert v (type ProcedurePackageRequest) to ProcedurePackage instead of using struct literal
pkg/sdk/procedures_impl_gen.go|258 col 11| should convert v (type ProcedureImportRequest) to ProcedureImport instead of using struct literal
pkg/sdk/procedures_impl_gen.go|267 col 11| should convert v (type ProcedureSecretRequest) to ProcedureSecret instead of using struct literal
pkg/sdk/procedures_impl_gen.go|299 col 11| should convert v (type ProcedureArgumentRequest) to ProcedureArgument instead of using struct literal
pkg/sdk/procedures_impl_gen.go|320 col 13| should convert v (type ProcedureColumnRequest) to ProcedureColumn instead of using struct literal
pkg/sdk/procedures_impl_gen.go|332 col 11| should convert v (type ProcedurePackageRequest) to ProcedurePackage instead of using struct literal
pkg/sdk/procedures_impl_gen.go|341 col 11| should convert v (type ProcedureImportRequest) to ProcedureImport instead of using struct literal
pkg/sdk/procedures_impl_gen.go|367 col 11| should convert v (type ProcedureArgumentRequest) to ProcedureArgument instead of using struct literal
pkg/sdk/procedures_impl_gen.go|388 col 13| should convert v (type ProcedureColumnRequest) to ProcedureColumn instead of using struct literal
pkg/sdk/procedures_impl_gen.go|414 col 11| should convert v (type ProcedureArgumentTypeRequest) to ProcedureArgumentType instead of using struct literal
pkg/sdk/procedures_impl_gen.go|444 col 11| should convert v (type ProcedureArgumentTypeRequest) to ProcedureArgumentType instead of using struct literal
pkg/sdk/procedures_impl_gen.go|461 col 23| func procedureRow.convert is unused
pkg/sdk/procedures_impl_gen.go|480 col 11| should convert v (type ProcedureArgumentTypeRequest) to ProcedureArgumentType instead of using struct literal
pkg/sdk/procedures_impl_gen.go|489 col 29| func procedureDetailRow.convert is unused

github-actions · 2023-11-22T07:35:00Z

pkg/sdk/procedures_gen.go

+
+// CreateProcedureForJavaProcedureOptions is based on https://docs.snowflake.com/en/sql-reference/sql/create-procedure.
+type CreateProcedureForJavaProcedureOptions struct {
+	create                     bool                        `ddl:"static" sql:"CREATE"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field create is unused

github-actions · 2023-11-22T07:35:00Z

pkg/sdk/procedures_gen.go

+	create                     bool                        `ddl:"static" sql:"CREATE"`
+	OrReplace                  *bool                       `ddl:"keyword" sql:"OR REPLACE"`
+	Secure                     *bool                       `ddl:"keyword" sql:"SECURE"`
+	procedure                  bool                        `ddl:"static" sql:"PROCEDURE"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field procedure is unused

github-actions · 2023-11-22T07:35:00Z

pkg/sdk/procedures_gen.go

+	Arguments                  []ProcedureArgument         `ddl:"parameter,parentheses,no_equals"`
+	CopyGrants                 *bool                       `ddl:"keyword" sql:"COPY GRANTS"`
+	Returns                    *ProcedureReturns           `ddl:"keyword" sql:"RETURNS"`
+	languageJava               bool                        `ddl:"static" sql:"LANGUAGE JAVA"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field languageJava is unused

github-actions · 2023-11-22T07:35:00Z

pkg/sdk/procedures_gen.go

+
+// CreateProcedureForJavaScriptProcedureOptions is based on https://docs.snowflake.com/en/sql-reference/sql/create-procedure.
+type CreateProcedureForJavaScriptProcedureOptions struct {
+	create              bool                        `ddl:"static" sql:"CREATE"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field create is unused

github-actions · 2023-11-22T07:35:00Z

pkg/sdk/procedures_gen.go

+	create              bool                        `ddl:"static" sql:"CREATE"`
+	OrReplace           *bool                       `ddl:"keyword" sql:"OR REPLACE"`
+	Secure              *bool                       `ddl:"keyword" sql:"SECURE"`
+	procedure           bool                        `ddl:"static" sql:"PROCEDURE"`


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
field procedure is unused

github-actions · 2023-11-22T07:35:02Z

pkg/sdk/procedures_impl_gen.go

+	if r.Packages != nil {
+		s := make([]ProcedurePackage, len(r.Packages))
+		for i, v := range r.Packages {
+			s[i] = ProcedurePackage{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type ProcedurePackageRequest) to ProcedurePackage instead of using struct literal

github-actions · 2023-11-22T07:35:02Z

pkg/sdk/procedures_impl_gen.go

+	if r.Imports != nil {
+		s := make([]ProcedureImport, len(r.Imports))
+		for i, v := range r.Imports {
+			s[i] = ProcedureImport{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type ProcedureImportRequest) to ProcedureImport instead of using struct literal

github-actions · 2023-11-22T07:35:02Z

pkg/sdk/procedures_impl_gen.go

+	if r.Secrets != nil {
+		s := make([]ProcedureSecret, len(r.Secrets))
+		for i, v := range r.Secrets {
+			s[i] = ProcedureSecret{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type ProcedureSecretRequest) to ProcedureSecret instead of using struct literal

github-actions · 2023-11-22T07:35:02Z

pkg/sdk/procedures_impl_gen.go

+	if r.Arguments != nil {
+		s := make([]ProcedureArgument, len(r.Arguments))
+		for i, v := range r.Arguments {
+			s[i] = ProcedureArgument{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type ProcedureArgumentRequest) to ProcedureArgument instead of using struct literal

github-actions · 2023-11-22T07:35:02Z

pkg/sdk/procedures_impl_gen.go

+	if r.Arguments != nil {
+		s := make([]ProcedureArgument, len(r.Arguments))
+		for i, v := range r.Arguments {
+			s[i] = ProcedureArgument{


🚫 [staticcheck] <S1016> _{reported by reviewdog 🐶}
should convert v (type ProcedureArgumentRequest) to ProcedureArgument instead of using struct literal

pkg/sdk/procedures_def.go

pkg/sdk/procedures_gen.go

pkg/sdk/testint/procedures_integration_test.go

sfc-gh-jcieslak · 2023-11-22T16:01:01Z

pkg/sdk/testint/procedures_integration_test.go

+		id := sdk.NewSchemaObjectIdentifier(databaseTest.Name, schemaTest.Name, name)
+
+		as := `
+import joblib


We should probably run those with go-snowflake exec and implement proper call function in the following pr ?

i dont think this is necessary

But we are going for all of the functionalities in the SDK, right ? Maybe we should create at least a follow-up task on creating a call / call with functions to invoke those procedures with SDK

added todo comment for this test

/*
todo: add custom operation for:

call and call-with for scripting https://docs.snowflake.com/en/sql-reference/sql/call
*/

pkg/sdk/testint/procedures_integration_test.go

github-actions · 2023-12-04T08:11:59Z

Integration tests failure for a0f9ccdf90b127d39958f4e8d7e47c67ece91bea

github-actions · 2023-12-04T08:21:54Z

Integration tests failure for ecf18a02c7c3fabfa58e3b3630521c5e289aed12

sfc-gh-asawicki

Small ones, and also the build checks are failing, please look at them

pkg/sdk/poc/generator/keyword_builders.go

pkg/sdk/testint/procedures_integration_test.go

…orm-provider-snowflake into procedures

github-actions · 2023-12-07T07:56:05Z

Integration tests failure for 5e9c2c263d388a964a0337c8556aece4f1bca7cf

github-actions · 2023-12-07T07:56:18Z

Integration tests failure for 5e2469f74549885befccbbca97e23f4e5ee83648

sfc-gh-jcieslak

Here also #2202 (comment) other than the comment it's 👍 for me
🥇

…orm-provider-snowflake into procedures

github-actions · 2023-12-08T08:13:56Z

Integration tests failure for 948f478fc2b9d4603e7259f223fd82114eae88d8

github-actions · 2023-12-08T21:52:09Z

Integration tests failure for 99b8e6362e13592004e7c3c1c3040c7c163500ab

github-actions · 2023-12-08T21:55:41Z

Integration tests failure for e791214bcf13c282fd7d710d46dbe2de1c81e034

add procedures to sdkv2

5dba820

github-actions bot reviewed Nov 21, 2023

View reviewed changes

sfc-gh-asawicki requested changes Nov 21, 2023

View reviewed changes

update

d63b18c

github-actions bot reviewed Nov 22, 2023

View reviewed changes

sfc-gh-jcieslak requested changes Nov 22, 2023

View reviewed changes

sfc-gh-swinkler added 2 commits December 3, 2023 23:42

update procedures

a0f9ccd

Merge branch 'main' into procedures

ecf18a0

sfc-gh-asawicki requested changes Dec 4, 2023

View reviewed changes

pkg/sdk/poc/generator/keyword_builders.go Show resolved Hide resolved

pkg/sdk/testint/procedures_integration_test.go Show resolved Hide resolved

sfc-gh-swinkler added 3 commits December 6, 2023 23:52

fmt

313cb3b

Merge branch 'procedures' of https://github.com/Snowflake-Labs/terraf…

5e9c2c2

…orm-provider-snowflake into procedures

Merge branch 'main' into procedures

5e2469f

sfc-gh-jcieslak previously approved these changes Dec 7, 2023

View reviewed changes

sfc-gh-asawicki self-requested a review December 7, 2023 16:26

sfc-gh-swinkler added 2 commits December 7, 2023 23:49

update proc

bab1be8

Merge branch 'procedures' of https://github.com/Snowflake-Labs/terraf…

2c96174

…orm-provider-snowflake into procedures

sfc-gh-swinkler dismissed sfc-gh-jcieslak’s stale review via 2c96174 December 8, 2023 07:49

Merge branch 'main' into procedures

948f478

sfc-gh-asawicki previously approved these changes Dec 8, 2023

View reviewed changes

update comments

99b8e63

sfc-gh-swinkler dismissed sfc-gh-asawicki’s stale review via 99b8e63 December 8, 2023 21:19

Merge branch 'main' into procedures

e791214

sfc-gh-swinkler merged commit 6b563ac into main Dec 8, 2023
4 of 7 checks passed

sfc-gh-swinkler deleted the procedures branch December 8, 2023 21:22

snowflake-release-please bot mentioned this pull request Dec 8, 2023

chore(main): release 0.79.0 #2247

Merged

feat: add procedures to sdkv2 #2202

feat: add procedures to sdkv2 #2202

Conversation

sfc-gh-swinkler commented Nov 21, 2023

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot Nov 22, 2023

Choose a reason for hiding this comment

sfc-gh-jcieslak Nov 22, 2023 • edited Loading

Choose a reason for hiding this comment

sfc-gh-swinkler Dec 4, 2023

Choose a reason for hiding this comment

sfc-gh-jcieslak Dec 4, 2023

Choose a reason for hiding this comment

sfc-gh-swinkler Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

sfc-gh-jcieslak left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 8, 2023

sfc-gh-jcieslak Nov 22, 2023 •

edited

Loading

sfc-gh-swinkler Dec 8, 2023 •

edited

Loading