-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic tables to sdk #2074
Conversation
Integration tests success for b255f2e448b11f1723931af5647436218cf5e4c0 |
Integration tests failure for f186f4664153e823769642e00eb95f2784ce198f |
Integration tests failure for fbb5615d910ab609b6c2657239450912ef8087ed |
@@ -347,6 +347,9 @@ func createDatabaseWithOptions(t *testing.T, client *Client, id AccountObjectIde | |||
require.NoError(t, err) | |||
return database, func() { | |||
err := client.Databases.Drop(ctx, id, nil) | |||
if err == errObjectNotExistOrAuthorized { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
@@ -366,6 +369,9 @@ func createSchemaWithIdentifier(t *testing.T, client *Client, database *Database | |||
require.NoError(t, err) | |||
return schema, func() { | |||
err := client.Schemas.Drop(ctx, schemaID, nil) | |||
if err == errObjectNotExistOrAuthorized { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
Integration tests failure for 4bf8fb75804d26eb62b9a04164802168f1a6b42c |
Integration tests failure for ba8b1ce6f85cbea98a5406ac1c8e655a7670ea5d |
Integration tests failure for 9bb3d8e8591963c660c36f8188880325a0d8d3c3 |
Integration tests success for 49fece63a0a1d8323f1afda4673a0f01a6494739 |
Integration tests failure for 8d6f1ac05b0319788b8c9092adfbc783a7c5327b |
Integration tests failure for e7c043c14056e4407ae1fefa883eafef5f5e1359 |
[SNOW-871686]
Adds dynamic tables to SDK