feat: support drop for accounts and fix read race condition #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests success for c1f3e0a1984c91e10876ed01e020cb9bb22f7610 |
sfc-gh-asawicki
requested changes
Sep 22, 2023
|
Integration tests failure for 51adf71cb055eddb256404a738e413ca484a30f0 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pkg/sdk/accounts_integration_test.go
Outdated
| t.Skip("Skipping TestInt_AccountCreate") | ||
| require.NoError(t, err) | ||
| _, err = client.Accounts.ShowByID(ctx, NewAccountObjectIdentifier("NOT_EXISTING_ACCOUNT")) | ||
| require.ErrorIs(t, err, ErrObjectNotExistOrAuthorized) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
undefined: ErrObjectNotExistOrAuthorized (typecheck)
pkg/sdk/accounts_integration_test.go
Outdated
| t.Skip("Skipping TestInt_AccountCreate") | ||
| require.NoError(t, err) | ||
| _, err = client.Accounts.ShowByID(ctx, NewAccountObjectIdentifier("NOT_EXISTING_ACCOUNT")) | ||
| require.ErrorIs(t, err, ErrObjectNotExistOrAuthorized) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
undefined: ErrObjectNotExistOrAuthorized) (typecheck)
|
Integration tests failure for 4d51c2a4917a4f337281d2200df014ebde87215d |
|
Integration tests failure for 77458c7a08f5cc0ce20c2c22b08d2b29fd306c38 |
|
Integration tests success for d139eec825724f8651c54adb7162607f7e2d548e |
sfc-gh-jcieslak
approved these changes
Sep 29, 2023
sfc-gh-asawicki
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake now supports drop and undrop operations on account
https://docs.snowflake.com/en/sql-reference/sql/drop-account
Also after creating an account, it doesn't always show up immediately, so add in some retry logic.
Finally, comments actually cannot be set on account so changing that back to force new. Also cannot rename an account that is not in the same account so removing that as well