-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tables to the SDK #2042
Conversation
…nowflake into tables-sdk-v2
Integration tests failure for e2523df6aeeb930c3e013a14253196ab80018501 |
Integration tests failure for bba3a83985f35e3556a4d4deb10a00f2ace4285a |
Integration tests failure for e4642af69f35964593715d1235c5d14cc06b3ca2 |
Integration tests failure for 0a659ffa278af752b6c176f5791f8942e8911a0d |
Integration tests failure for 06ae64cae35bbe07de16d1748d6a030071accd58 |
Integration tests failure for cb1ea66f4694b11d2abb1ae83c2d2c8eaec3cd66 |
Integration tests failure for 56ed0c8ad06dc546b7542b3f400b73267b2dca02 |
Integration tests failure for d0aed52e03168bffcf2b8b5f87ed46b55ce7ec9b |
Integration tests failure for ea2e35ac72fcbeebb7f378a2bdfd8b97e093b4a8 |
Integration tests failure for 6f924bdc0f015d96cc5abf33886b27f01b1769c9 |
This change was waiting really long to be finally merged. There were plenty of changes in the repository during this time. There were also some changes in the documentation. This is the first PR that aims to merge this functionality and correct/update it later in the following PR(s).
Changes
common_table_types.go
).Follow-up plan
createTable
function in helper with implementation using the newly created table clientShowByID
can be rewritten to use in database/in schema syntaxOperations NOT supported in this PR
ALTER TABLE <name> ALTER CONSTRAINT <constraint_name> ( <col_name> )
- it conforms with the documentation: https://docs.snowflake.com/en/sql-reference/sql/alter-table#syntax but fails withSyntax error: unexpected '('. (line 7)
Test Plan
References