-
Notifications
You must be signed in to change notification settings - Fork 426
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Add user parameters to resource (#2968)
This is the first of the next few changes being a part of the user resource rework. It includes: - adding user parameters to the user resource schema - adding the `parameters` collection to user schema - testing the behavior of parameters on user - a bunch of TODOs to move parameters definitions was left for the next PRs (this one is already too big) - missing assertions and config builders generated Checks for setting `TIMEZONE` may fail (skip added to the test messing with our account; it was cleaned with `ALTER ACCOUNT UNSET TIMEZONE` but still this test from other branches may interfere). Additionally: - logic to handle parameters has been slightly improved and made a bit more generic (with changes to databases and schemas; function to read database parameters was replaced with a more generic solution fixing SNOW-1480106) - one of the account parameters was messing with the change, so the test was temporarily skipped - new github issues added to the known issues list It does not include (it will be handled in the following PRs): - checking quotes for `DATE_INPUT_FORMAT` and `DATE_OUTPUT_FORMAT` - checking if zero is allowed for `CLIENT_MEMORY_LIMIT` - handling `snowflake_network_policy_attachment` - handling `snowflake_user_public_keys` - setting diff suppressions and validations for the parameters (it will be handled in the next PR) - moving the parameters logic fully to the SDK - reworking other attributes on the user resource - adding more acceptance tests
- Loading branch information
1 parent
824ec52
commit f4ae380
Showing
46 changed files
with
4,321 additions
and
637 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.