ref

Snowflake-Labs · Dec 18, 2024 · df0563b · df0563b
1 parent c60dec5
commit df0563b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/pkg/sdk/poc/generator/show_object_methods.go b/pkg/sdk/poc/generator/show_object_methods.go
@@ -70,6 +70,10 @@ func (s *Operation) withShowObjectMethods(structName string, showObjectMethodsKi
 				log.Printf("[WARN]: %v, for showObjectIdMethod", err)
 				continue
 			}
+			if !hasRequiredFieldsForIDMethod(structName, s.HelperStructs, id) {
+				log.Printf("[WARN]: Struct '%s' does not contain needed fields to build ID() helper method. Create the method manually in _ext file or add missing fields: %v.\n", structName, idTypeParts[id])
+				return nil
+			}
 			s.ShowObjectMethods = append(s.ShowObjectMethods, newShowObjectIDMethod(structName, s.HelperStructs, id))
 		case ShowObjectTypeMethod:
 			s.ShowObjectMethods = append(s.ShowObjectMethods, newShowObjectTypeMethod(structName))
@@ -81,13 +85,9 @@ func (s *Operation) withShowObjectMethods(structName string, showObjectMethodsKi
 }
 
 func newShowObjectIDMethod(structName string, helperStructs []*Field, idType objectIdentifier) *ShowObjectMethod {
-	if !hasRequiredFieldsForIDMethod(structName, helperStructs, idType) {
-		log.Printf("[WARN]: Struct '%s' does not contain needed fields to build ID() helper method. Create the method manually in _ext file or add missing fields: %v.\n", structName, idTypeParts[idType])
-		return nil
-	}
-	fields := idTypeParts[idType]
+	requiredFields := idTypeParts[idType]
 	var args string
-	for _, field := range fields {
+	for _, field := range requiredFields {
 		args += fmt.Sprintf("v.%v, ", field)
 	}