Run pre-push

Snowflake-Labs · Dec 8, 2024 · 086e202 · 086e202
1 parent b5123b1
commit 086e202
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 18 deletions.
diff --git a/pkg/acceptance/helpers/function_client.go b/pkg/acceptance/helpers/function_client.go
@@ -59,6 +59,7 @@ func (c *FunctionClient) CreateSecure(t *testing.T, arguments ...sdk.DataType) *
 }
 
 func (c *FunctionClient) CreateSql(t *testing.T) (*sdk.Function, func()) {
+	t.Helper()
 	dataType := testdatatypes.DataTypeFloat
 	id := c.ids.RandomSchemaObjectIdentifierWithArguments(sdk.LegacyDataTypeFrom(dataType))
 	return c.CreateSqlWithIdentifierAndArgument(t, id.SchemaObjectId(), dataType)

diff --git a/pkg/sdk/functions_ext.go b/pkg/sdk/functions_ext.go
@@ -109,41 +109,41 @@ func (d *FunctionDetail) setOptionalBoolValueOrError(property string, field **bo
 	return nil
 }
 
-func (s *CreateForJavaFunctionRequest) WithFunctionDefinitionWrapped(FunctionDefinition string) *CreateForJavaFunctionRequest {
-	s.FunctionDefinition = String(fmt.Sprintf(`$$%s$$`, FunctionDefinition))
+func (s *CreateForJavaFunctionRequest) WithFunctionDefinitionWrapped(functionDefinition string) *CreateForJavaFunctionRequest {
+	s.FunctionDefinition = String(fmt.Sprintf(`$$%s$$`, functionDefinition))
 	return s
 }
 
-func (s *CreateForPythonFunctionRequest) WithFunctionDefinitionWrapped(FunctionDefinition string) *CreateForPythonFunctionRequest {
-	s.FunctionDefinition = String(fmt.Sprintf(`$$%s$$`, FunctionDefinition))
+func (s *CreateForPythonFunctionRequest) WithFunctionDefinitionWrapped(functionDefinition string) *CreateForPythonFunctionRequest {
+	s.FunctionDefinition = String(fmt.Sprintf(`$$%s$$`, functionDefinition))
 	return s
 }
 
-func (s *CreateForScalaFunctionRequest) WithFunctionDefinitionWrapped(FunctionDefinition string) *CreateForScalaFunctionRequest {
-	s.FunctionDefinition = String(fmt.Sprintf(`$$%s$$`, FunctionDefinition))
+func (s *CreateForScalaFunctionRequest) WithFunctionDefinitionWrapped(functionDefinition string) *CreateForScalaFunctionRequest {
+	s.FunctionDefinition = String(fmt.Sprintf(`$$%s$$`, functionDefinition))
 	return s
 }
 
 func NewCreateForSQLFunctionRequestDefinitionWrapped(
 	name SchemaObjectIdentifier,
-	Returns FunctionReturnsRequest,
-	FunctionDefinition string,
+	returns FunctionReturnsRequest,
+	functionDefinition string,
 ) *CreateForSQLFunctionRequest {
 	s := CreateForSQLFunctionRequest{}
 	s.name = name
-	s.Returns = Returns
-	s.FunctionDefinition = fmt.Sprintf(`$$%s$$`, FunctionDefinition)
+	s.Returns = returns
+	s.FunctionDefinition = fmt.Sprintf(`$$%s$$`, functionDefinition)
 	return &s
 }
 
 func NewCreateForJavascriptFunctionRequestDefinitionWrapped(
 	name SchemaObjectIdentifier,
-	Returns FunctionReturnsRequest,
-	FunctionDefinition string,
+	returns FunctionReturnsRequest,
+	functionDefinition string,
 ) *CreateForJavascriptFunctionRequest {
 	s := CreateForJavascriptFunctionRequest{}
 	s.name = name
-	s.Returns = Returns
-	s.FunctionDefinition = fmt.Sprintf(`$$%s$$`, FunctionDefinition)
+	s.Returns = returns
+	s.FunctionDefinition = fmt.Sprintf(`$$%s$$`, functionDefinition)
 	return &s
 }
diff --git a/pkg/sdk/functions_gen_test.go b/pkg/sdk/functions_gen_test.go
@@ -830,7 +830,7 @@ func TestFunctions_CreateForScala(t *testing.T) {
 		opts.ReturnNullValues = ReturnNullValuesPointer(ReturnNullValuesNotNull)
 		opts.NullInputBehavior = NullInputBehaviorPointer(NullInputBehaviorCalledOnNullInput)
 		opts.ReturnResultsBehavior = ReturnResultsBehaviorPointer(ReturnResultsBehaviorImmutable)
-		opts.RuntimeVersion = String("2.0")
+		opts.RuntimeVersion = "2.0"
 		opts.Comment = String("comment")
 		opts.Imports = []FunctionImport{
 			{
@@ -859,7 +859,7 @@ func TestFunctions_CreateForScala(t *testing.T) {
 		opts.ReturnNullValues = ReturnNullValuesPointer(ReturnNullValuesNotNull)
 		opts.NullInputBehavior = NullInputBehaviorPointer(NullInputBehaviorCalledOnNullInput)
 		opts.ReturnResultsBehavior = ReturnResultsBehaviorPointer(ReturnResultsBehaviorImmutable)
-		opts.RuntimeVersion = String("2.0")
+		opts.RuntimeVersion = "2.0"
 		opts.Comment = String("comment")
 		opts.Imports = []FunctionImport{
 			{

diff --git a/pkg/sdk/testint/functions_integration_test.go b/pkg/sdk/testint/functions_integration_test.go
@@ -51,6 +51,7 @@ func TestInt_Functions(t *testing.T) {
 	tmpPythonFunction := testClientHelper().CreateSamplePythonFunctionAndModule(t)
 
 	assertParametersSet := func(t *testing.T, functionParametersAssert *objectparametersassert.FunctionParametersAssert) {
+		t.Helper()
 		assertions.AssertThatObject(t, functionParametersAssert.
 			HasEnableConsoleOutput(true).
 			HasLogLevel(sdk.LogLevelWarn).
@@ -567,7 +568,7 @@ func TestInt_Functions(t *testing.T) {
 
 		assertions.AssertThatObject(t, objectassert.FunctionDetails(t, function.ID()).
 			HasSignature(fmt.Sprintf(`(%s %s)`, argName, dataType.ToLegacyDataTypeSql())).
-			HasReturns(strings.ReplaceAll(dataType.ToSql(), " ", "")). //TODO [SNOW-1348103]: do we care about this whitespace?
+			HasReturns(strings.ReplaceAll(dataType.ToSql(), " ", "")). // TODO [SNOW-1348103]: do we care about this whitespace?
 			HasLanguage("PYTHON").
 			HasBody(definition).
 			HasNullHandling(string(sdk.NullInputBehaviorCalledOnNullInput)).
@@ -1248,7 +1249,7 @@ func TestInt_Functions(t *testing.T) {
 			HasBody(definition).
 			HasNullHandlingNil().
 			// TODO [SNOW-1348103]: volatility is not returned and is present in create syntax
-			//HasVolatility(string(sdk.ReturnResultsBehaviorImmutable)).
+			// HasVolatility(string(sdk.ReturnResultsBehaviorImmutable)).
 			HasVolatilityNil().
 			HasExternalAccessIntegrationsNil().
 			HasSecretsNil().