Assert environment variables upon starting #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-dasilva and
sfc-gh-yayin
as code owners
sfc-gh-yayin
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #92.
It's easy to overlook the required environment variable setup to run this app. Additionally, it was a bit confusing that in the UI we showed the option to edit the credentials, but this didn't actually take effect.
Since these environment variables are unlikely to change significantly run to run, I'm removing them entirely from the UI, and adding a step on app startup that asserts that all of the required vars are set. If one is missing, there is a more clear error shown and instructions provided.
Testing
Omit one of the required environment variables from the setup instructions, and observe that you see a popup.