Remove TODO expr in filters #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jhilgart
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-nlimtiaco and
sfc-gh-dasilva
as code owners
| @@ -314,7 +314,7 @@ def mock_dependencies_exceed_context(mock_snowflake_connection): | |||
| def test_raw_schema_to_semantic_context( | |||
| mock_dependencies, mock_snowflake_connection, mock_snowflake_connection_env | |||
| ): | |||
| want_yaml = "name: this is the best semantic model ever\ntables:\n - name: ALIAS\n description: some table comment\n base_table:\n database: TEST_DB\n schema: SCHEMA_TEST\n table: ALIAS\n filters:\n - name: ' '\n synonyms:\n - ' '\n description: ' '\n expr: ' '\n dimensions:\n - name: ZIP_CODE\n synonyms:\n - ' '\n description: some column comment\n expr: ZIP_CODE\n data_type: TEXT\n time_dimensions:\n - name: BAD_ALIAS\n synonyms:\n - ' '\n description: ' '\n expr: BAD_ALIAS\n data_type: TIMESTAMP\n measures:\n - name: AREA_CODE\n synonyms:\n - ' '\n description: ' '\n expr: AREA_CODE\n data_type: NUMBER\n - name: CBSA\n synonyms:\n - ' '\n description: ' '\n expr: CBSA\n data_type: NUMBER\n" | |||
| want_yaml = "name: this is the best semantic model ever\ntables:\n - name: ALIAS\n description: some table comment\n base_table:\n database: TEST_DB\n schema: SCHEMA_TEST\n table: ALIAS\n filters:\n - name: ' '\n synonyms:\n - ' '\n description: ' '\n dimensions:\n - name: ZIP_CODE\n synonyms:\n - ' '\n description: some column comment\n expr: ZIP_CODE\n data_type: TEXT\n time_dimensions:\n - name: BAD_ALIAS\n synonyms:\n - ' '\n description: ' '\n expr: BAD_ALIAS\n data_type: TIMESTAMP\n measures:\n - name: AREA_CODE\n synonyms:\n - ' '\n description: ' '\n expr: AREA_CODE\n data_type: NUMBER\n - name: CBSA\n synonyms:\n - ' '\n description: ' '\n expr: CBSA\n data_type: NUMBER\n" | |||
There was a problem hiding this comment.
oh, the expr is also auto-populated for filters.
I thought this model'll still be broken without expr for filters?
There was a problem hiding this comment.
You're right. Looking
There was a problem hiding this comment.
one thought maybe we mark the whole filter area as comments.... and let user know you can uncomment if you want to add filter
There was a problem hiding this comment.
I thought this was the issue, but turns out this is a valid filter.
filters:
- name: ' ' # <FILL-OUT>
synonyms:
- ' ' # <FILL-OUT>
description: ' ' # <FILL-OUT>
expr: ' ' # <FILL-OUT>
And we already include the col name in the expr (so we are generating valid yaml in this generator).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're adding default filters that include a blank
expr. However, during validation this returns an error. Now, the default filter will pass validation, but not add value until a user updates it.