Remove analyst generation comment from verified queries #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
requested review from
sfc-gh-yayin and
sfc-gh-jsummer
as code owners
sfc-gh-jsummer
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries generated by Analyst include a
--Generated by Cortex Analystcomment for attribution. When directly adding these as verified queries using the OSS, the comment was being left in. When the Analyst then took into account these verified queries to generate subsequent SQL, the comment was being preserved and added twice (once because the LLM preserved the original comment from the verified query, and again by the Analyst code to append this comment to any SQL queries generated), which looks strange.To solve this we are removing the comment before marking the query as a verified query so that Analyst will not encounter it again.
CleanShot.2024-10-01.at.11.51.06.mp4