UI for editing join keys #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
commented
Sep 26, 2024
| mime="text/yaml", | ||
| use_container_width=True, | ||
| help=DOWNLOAD_HELP, | ||
| def validate_and_update_session_state() -> None: |
There was a problem hiding this comment.
Diff in this file is a bit complicated to read, but I'm essentially just:
- Moving the validation logic to a common function so that I can run it before the user clicks "Add joins", saving them a button click for validating
- Adding a new button for "Add joins"
sfc-gh-cnivera
requested review from
sfc-gh-yayin and
sfc-gh-jsummer
as code owners
sfc-gh-jsummer
requested changes
Sep 26, 2024
sfc-gh-jsummer
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a UI within the edit flow for specifying join paths. It is only shown if the user has experimental features enabled.
The UI is used to add and edit join paths between two tables, specifying the join/relationship type as well as the join keys. Upon submitting, the joins are serialized into the YAML.
CleanShot.2024-09-26.at.10.53.05.mp4