Jsummer/add dbt model instructions #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jsummer
requested review from
sfc-gh-cnivera and
sfc-gh-yayin
as code owners
sfc-gh-cnivera
approved these changes
Sep 24, 2024
admin_apps/partner/partner_utils.py
Outdated
| @@ -24,13 +24,19 @@ def set_partner_instructions() -> None: | |||
| """ | |||
|
|
|||
| if st.session_state.get("partner_tool", None): | |||
| if st.session_state["partner_tool"] == "dbt": | |||
| from admin_apps.partner.dbt import DBT_IMAGE, DBT_INSTRUCTIONS | |||
| if st.session_state["partner_tool"] == "dbt - SQL Model": | |||
There was a problem hiding this comment.
not required, but if we feel like these raw strings of the selected partner tool appear in lots of places of the codebase, might be worth defining an enum for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit instructions for dbt SQL models vs. dbt semantic models. Distinguish Looker integration as support for Explore specifically. Lastly, resolve bug with previously validated semantic file not registered when merging partner metadata.