Add skeleton joins section on model creation #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
commented
Sep 17, 2024
|
|
||
| if in_section: | ||
| comment_indent = " " * section_indent_level | ||
| current_indent_level = len(line) - len(line.lstrip()) |
There was a problem hiding this comment.
just including some quick changes to preserve indentation level when sections are commented out - makes it a bit easier for the user to preserve the correct indentation if uncommenting
sfc-gh-cnivera
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-dasilva,
sfc-gh-yayin and
sfc-gh-jsummer
as code owners
sfc-gh-rehuang
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
looks good to me, thanks for adding!
One thing:
can we comment in join_type and relationship_type fields only below values are supported?
for join_type: inner and left_outer
for relationship _type: one_to_one and many_to_one
(see semantic_model.proto definition in our cortex/ repo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are gating join support behind an "experimental features" checkbox in the UI. When enabled, we will allow for new features such as joins to be supported in the semantic model generator. Note that users must have the prerequisite parameters enabled in their Snowflake accounts for this to properly work.
For now, we'd like to expose the joins via a commented out section to simply inform the user of the option. We will quickly follow up by building an actual UI for selecting tables and their join keys.