Mark looker_sdk
as an optional dependency
#151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may not want to run through partner flows, in which case installing the Looker SDK is unnecessary. Following the discussion in #150 (comment), this PR moves
looker-sdk
into the "extra" dependencies section, meaning it won't be installed unless specified (e.g.poetry install -E looker
).To support this, I made some small refactors to only import looker conditionally. The popup will now be triggered if the user attempts to click the "Start with partner semantic model" button.
Shown below is a video showing that without looker installed, the rest of the app is functional, and a warning pops up if a user attempts to use the Looker integration without the SDK.
CleanShot.2024-09-10.at.14.30.06.mp4