Dropdown selectors for iteration flow #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-dasilva,
sfc-gh-yayin and
sfc-gh-kchang
as code owners
sfc-gh-kchang
approved these changes
Aug 1, 2024
sfc-gh-cnivera
force-pushed
the
cnivera/iteration-dropdowns
branch
from
ccbb17d to
62051bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the free text entry fields in the iteration flow with dropdowns, so that the user can click to select their file instead of having to type everything in manually. This fully completes #94 .
Testing
Go through the iteration flow and verify functionality of the dropdown selectors. Proceed to use the app and upload your YAML to a stage.
Additionally, go through the builder flow, and verify that the step where you select the Snowflake stage at the end works with the new dropdown selectors.