Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a MPA design and proto definition. #350

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

stvnrhodes
Copy link
Contributor

I've prototyped this enough in https://github.com/stvnrhodes/sansshell/tree/mpa to have reasonable confidence that this design is implementable. I'm separating out the design and proto into an initial PR so that we can make sure that we agree on the high-level direction before we deeply review any implementation.

The readme is meant to be used as long-term documentation on how to use MPA.

Part of #346

@sfc-gh-srhodes sfc-gh-srhodes marked this pull request as ready for review October 13, 2023 23:04
Copy link
Collaborator

@sfc-gh-ajoyner sfc-gh-ajoyner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big picture looks right, so I'm going to go ahead and smash Approve. I've left some comments we can discuss here, or that you can consider food-for-thought as the implementation develops. None of them are show-stoppers, for sure.

services/mpa/README.md Outdated Show resolved Hide resolved
services/mpa/mpa.proto Show resolved Hide resolved
services/mpa/mpa.proto Show resolved Hide resolved
I've prototyped this enough in https://github.com/stvnrhodes/sansshell/tree/mpa to have reasonable confidence that this design is implementable. I'm separating out the design and proto into an initial PR so that we can make sure that we agree on the high-level direction before we deeply review any implementation.

The readme is meant to be used as long-term documentation on how to use MPA.

Part of Snowflake-Labs#346
@sfc-gh-srhodes sfc-gh-srhodes merged commit f8d2ce3 into Snowflake-Labs:main Oct 24, 2023
4 checks passed
@stvnrhodes stvnrhodes deleted the mpa-design branch October 24, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants