Close stream when there's an error from target #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when proxy receives an error from a target, it might return a policy evaluation cancelled error instead the actual error from the target.
Policy evaluation cancelled error looks like:
This is because proxy doesn't immediately close the stream and return the error. It might still be proceeding with executing policy evaluation, which then gets cancelled.
As a result, proxy returns a policy evaluation cancelled error to the client, not the actual error.
Solution
Close stream immediately when receiving error from a target.