check if Tlsconfig is nil

services/httpoverrpc/server/server.go

@@ -65,12 +65,13 @@ func (s *server) Host(ctx context.Context, req *pb.HostHTTPRequest) (*pb.HTTPRep
 	for _, header := range req.Request.Headers {
 		httpReq.Header[header.Key] = header.Values
 	}
-	client := &http.Client{
-		Transport: &http.Transport{
+	client := &http.Client{}
+	if req.Tlsconfig != nil {
+		client.Transport = &http.Transport{
 			TLSClientConfig: &tls.Config{
 				InsecureSkipVerify: req.Tlsconfig.InsecureSkipVerify,
 			},
-		},
+		}
 	}
 	client.CheckRedirect = func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }
 

services/httpoverrpc/server/server_test.go

@@ -32,6 +32,7 @@ import (
 	"github.com/Snowflake-Labs/sansshell/services/httpoverrpc"
 	"github.com/Snowflake-Labs/sansshell/testing/testutil"
 	"github.com/google/go-cmp/cmp"
+	"github.com/stretchr/testify/assert"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/credentials/insecure"
 	"google.golang.org/grpc/test/bufconn"
@@ -184,6 +185,9 @@ func TestServer(t *testing.T) {
 		Port:     int32(httpPort),
 		Protocol: "https",
 		Hostname: "localhost",
+		Tlsconfig: &httpoverrpc.TLSConfig{
+			InsecureSkipVerify: true,
+		},
 	})
 	if err != nil {
 		t.Fatal(err)
@@ -212,4 +216,16 @@ func TestServer(t *testing.T) {
 	if !cmp.Equal(got, want, protocmp.Transform()) {
 		t.Fatalf("want %v, got %v", want, got)
 	}
+
+	// without insecureSkipVerify, should get an error
+	got, err = client.Host(ctx, &httpoverrpc.HostHTTPRequest{
+		Request: &httpoverrpc.HTTPRequest{
+			Method:     "POST",
+			RequestUri: "/register",
+		},
+		Port:     int32(httpPort),
+		Protocol: "https",
+		Hostname: "localhost",
+	})
+	assert.ErrorContains(t, err, "failed to verify certificate:")
 }