Skip to content

Commit

Permalink
Restore old proto tags (#327)
Browse files Browse the repository at this point in the history
In #297, we changed a proto tag number from 19 to 20, breaking backwards compatibility. This restores the old tag number.

I'm reserving tag 20 because I prefer never reusing fields that were used before, even briefly.
  • Loading branch information
sfc-gh-srhodes authored Sep 21, 2023
1 parent dadbbc2 commit 0a1f949
Show file tree
Hide file tree
Showing 3 changed files with 85 additions and 83 deletions.
160 changes: 80 additions & 80 deletions services/fdb/fdb.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions services/fdb/fdb.proto
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,10 @@ message FDBCLIRequest {
google.protobuf.Int32Value timeout = 18;
// Maps to --knob_<knob_name>=<knob_value>
// Provide a comma-separated list in the form "<knob_name1>=<knob_value1>,<knob_name2>=<knob_value2>, ..."
google.protobuf.StringValue knobs = 19;
repeated FDBCLICommand commands = 20;
google.protobuf.StringValue knobs = 21;
repeated FDBCLICommand commands = 19;

reserved 20;
}

message Log {
Expand Down
2 changes: 1 addition & 1 deletion services/fdb/fdb_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0a1f949

Please sign in to comment.