Add try/except logic to safely parse JSON objects #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-twhite
requested changes
Nov 27, 2024
There was a problem hiding this comment.
It looks like this file has some conflicts. These changes have landed already.
Could you update your branch to reflect what's in main? Something like this:
git checkout fix-try-except-json
git fetch upstream
git merge upstream/main
agent_gateway/gateway/planner.py
Outdated
Comment on lines
285
to
320
|
|
||
| async def plan(self, inputs: dict, is_replan: bool, **kwargs: Any): | ||
| llm_response = await self.run_llm( | ||
| inputs=inputs, | ||
| is_replan=is_replan, | ||
| ) | ||
| llm_response = llm_response + "\n" | ||
| plan_response = self.output_parser.parse(llm_response) | ||
| return plan_response | ||
|
|
||
| async def aplan( | ||
| self, | ||
| inputs: dict, | ||
| task_queue: asyncio.Queue[Optional[str]], | ||
| is_replan: bool, | ||
| **kwargs: Any, | ||
| ) -> Plan: | ||
| """Given input, asynchronously decide what to do.""" | ||
| aplan_response = self.run_llm(inputs=inputs, is_replan=is_replan) | ||
| await aplan_response |
There was a problem hiding this comment.
We will need this code still. This is used here:
orchestration-framework/agent_gateway/gateway/gateway.py
Lines 163 to 170 in b1d6016
|
Closing in favor of #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a try/except block to handle JSON decoding errors in the _parse_snowflake_response function.
Let me know if any further changes are required!