Skip to content

Commit

Permalink
mobile: Default QUIC connection idle timeout to 60s (envoyproxy#37633)
Browse files Browse the repository at this point in the history
Experimentation has shown 60s to be a good default value.

---------

Signed-off-by: Ali Beyad <[email protected]>
  • Loading branch information
abeyad authored Dec 16, 2024
1 parent e4d5ceb commit 54e1f3a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion mobile/library/cc/engine_builder.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ class EngineBuilder {
// https://source.chromium.org/chromium/chromium/src/+/main:net/quic/quic_context.cc;l=21-22;drc=6849bf6b37e96bd1c38a5f77f7deaa28b53779c4;bpv=1;bpt=1
const uint32_t initial_stream_window_size_ = 6 * 1024 * 1024; // 6MB
const uint32_t initial_connection_window_size_ = 15 * 1024 * 1024; // 15MB
int quic_connection_idle_timeout_seconds_ = 30;
int quic_connection_idle_timeout_seconds_ = 60;

int keepalive_initial_interval_ms_ = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion mobile/test/cc/unit/envoy_config_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ TEST(TestConfig, ConfigIsApplied) {
"canonical_suffixes: \".opq.com\"",
"canonical_suffixes: \".xyz.com\"",
"num_timeouts_to_trigger_port_migration { value: 4 }",
"idle_network_timeout { seconds: 30 }",
"idle_network_timeout { seconds: 60 }",
"key: \"dns_persistent_cache\" save_interval { seconds: 101 }",
"key: \"prefer_quic_client_udp_gro\" value { bool_value: true }",
"key: \"test_feature_false\" value { bool_value: true }",
Expand Down

0 comments on commit 54e1f3a

Please sign in to comment.