Add Resource Connection to __construct so that the connection table name comes through with any prefixes #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Resource Model to __construct so that the connection table name comes through with any prefixes
|
@antbates91 thanks for your contribution, I created an internal ticket SMM-25, once our dev team will review the code we can add it to the next release. |
|
Merged and released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #346
Add Resource Connection to __construct so that the connection table name comes through with any prefixes
Currently, when installed on an instance with a database prefix, the node saving fails with table 'databasename.snowmenu_customer' not found.
This is because
$this->getConnection();uses a resource that has been instantiated without the concept of Magento database prefixes.Replication Steps
table 'databasename.snowmenu_customer' not found.is show.