-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to configure pre- and post-testtasks per test #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good! 👏
Some minor comments regarding style, but otherwise good to go.
src/main/kotlin/de/smartsquare/squit/config/ConfigExtensions.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/de/smartsquare/squit/config/ConfigExtensions.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/de/smartsquare/squit/config/ConfigExtensionsTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/de/smartsquare/squit/task/SquitRequestTaskConfigurableTasksTest.kt
Outdated
Show resolved
Hide resolved
I just noticed: We should also extend the README with the new config options. |
- add new config options to README - some refactoring
…ript execution time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
This PR adds 2 new config options:
preTestTasks
andpostTestTasks
With these options the execution of
RunnerScripts
,Runners
andDatabaseScripts
can be toggled and ordered.If not provided the default order is applied.