Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to configure pre- and post-testtasks per test #25

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

RuepInc
Copy link

@RuepInc RuepInc commented Jun 21, 2024

This PR adds 2 new config options:

preTestTasks and postTestTasks

With these options the execution of RunnerScripts, Runners and DatabaseScripts can be toggled and ordered.
If not provided the default order is applied.

@RuepInc RuepInc requested a review from rubengees June 21, 2024 09:46
Copy link
Member

@rubengees rubengees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! 👏

Some minor comments regarding style, but otherwise good to go.

@rubengees
Copy link
Member

I just noticed: We should also extend the README with the new config options.

Thomas Sievert added 2 commits June 25, 2024 08:54
- add new config options to README
- some refactoring
Copy link
Member

@rubengees rubengees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

README.md Outdated Show resolved Hide resolved
@rubengees rubengees merged commit c63cf4c into main Jun 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants