remove URLEncoder in makeLabeledURI (#146)

SmartTokenLabs · Jun 30, 2021 · 1086a4a · 1086a4a
1 parent 296c391
commit 1086a4a
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/main/java/com/alphawallet/attestation/IdentifierAttestation.java b/src/main/java/com/alphawallet/attestation/IdentifierAttestation.java
@@ -156,9 +156,14 @@ public IdentifierAttestation(byte[] derEncoding) throws IOException, IllegalArgu
     }
   }
 
-  private X500Name makeLabeledURI(String type, String identifier)  {
-    DERUTF8String labelValue = new DERUTF8String(URLEncoder.encode(identifier + " " + type, StandardCharsets.UTF_8));
-    RDN rdn = new RDN(LABELED_URI, labelValue);
+  /**
+   * @param label the label of the URL, similar to what is inside <a>...</a>
+   * @param URL the URL itself, similar to what is in <a href="...">, note that
+   * it should already be URLencoded therefore not containing space
+   */
+  private X500Name makeLabeledURI(String label, String URL)  {
+    DERUTF8String labeledURLValue = new DERUTF8String(URL + " " + label);
+    RDN rdn = new RDN(LABELED_URI, labeledURLValue);
     return new X500Name(new RDN[] {rdn});
   }