-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TestSoundService #4180
base: master
Are you sure you want to change the base?
Added TestSoundService #4180
Conversation
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
Thanks for your first PR thank you for reviewing it. |
Does this cover all of the soundservice? |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4180/36b32aa5
|
It should, I get all the element in the In fact the It is complete unless the |
Description
Unit tests for new sound system
Proposed changes
Adding unitest
Related Issues (if applicable)
Resolves #3881, #2844, #3880
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values