Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dupe glitch with backpacks #4134

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Feb 17, 2024

Description

This PR fixes a dupe glitch with backpacks. There was a race condition in PlayerProfile where the UUID got removed from the loading map before it was finished loading and inserted into the Registry. This meant that the PlayerProfile could load twice if someone did something like spam open a backpack after joining.
We now finish loading and adding to the registry before marking it as no longer loading.

Proposed changes

Move where we finish loading (remove from the loading map) to ensure we're always after the registry.

Related Issues (if applicable)

Fixes #4130
possibly fix for #4131

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner February 17, 2024 16:50
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Feb 17, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Feb 17, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 992a1229

https://preview-builds.walshy.dev/download/Slimefun/4134/992a1229

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Sfiguz7 Sfiguz7 merged commit 3301a77 into Slimefun:master Feb 17, 2024
14 checks passed
@J3fftw1 J3fftw1 deleted the fix/dupe-glitch-with-backpacks branch February 17, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item dupe with backpacks and a big player profile
3 participants