Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a dupe glitch with backpacks. There was a race condition in PlayerProfile where the UUID got removed from the loading map before it was finished loading and inserted into the Registry. This meant that the PlayerProfile could load twice if someone did something like spam open a backpack after joining.
We now finish loading and adding to the registry before marking it as no longer loading.
Proposed changes
Move where we finish loading (remove from the loading map) to ensure we're always after the registry.
Related Issues (if applicable)
Fixes #4130
possibly fix for #4131
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values