Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yaw to GPS Waypoint Location #4021

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

test137E29B
Copy link
Contributor

Description

Currently GPS Waypoints use the Block's Location (and thus Yaw). This means the player always is south facing when spawning as the default is 0.

Proposed changes

Preserve the Yaw of the player when creating GPS Marker Waypoints.

Related Issues (if applicable)

N?A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@test137E29B test137E29B requested a review from a team as a code owner November 10, 2023 21:50
@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Nov 10, 2023
Copy link
Contributor

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: b46a56ca

https://preview-builds.walshy.dev/download/Slimefun/4021/b46a56ca

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sfiguz7 Sfiguz7 merged commit 6efc0a1 into Slimefun:master Dec 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants