Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ButcherAndroidListener.java #4007

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Update ButcherAndroidListener.java #4007

merged 2 commits into from
Dec 6, 2023

Conversation

Kub94ekCZ
Copy link
Contributor

@Kub94ekCZ Kub94ekCZ commented Oct 25, 2023

Fixed bug with emerald drop from vindicators when killed by Butcher Android

Description

I'm making this pull request to fix the bug with vindicators don't drop emeralds when killed by Butcher Android

Proposed changes

I just added code to fix the bug

Related Issues (if applicable)

Resolves #3849

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Fixed bug with emerald drop from vindicators when killed by Butcher Android
@Kub94ekCZ Kub94ekCZ requested a review from a team as a code owner October 25, 2023 14:49
@github-actions
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change this system but that's out of scope, LGTM

@JustAHuman-xD JustAHuman-xD added the ✨ Fix This Pull Request fixes an issue. label Oct 25, 2023
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 9c594474

https://preview-builds.walshy.dev/download/Slimefun/4007/9c594474

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (we ignore i missed that previously)

@Sfiguz7 Sfiguz7 merged commit f8dfd75 into Slimefun:master Dec 6, 2023
9 checks passed
@Kub94ekCZ Kub94ekCZ deleted the patch-1 branch December 22, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

butcher android wont get emeralds from vindicators
3 participants