Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed removing EChests from Tuner and Tuner opening in other GUIs #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed removing EChests from Tuner and Tuner opening in other GUIs #90

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9846ad9
Fixed removing ender chests and tuner opening in other GUIs
Sefiraat Jul 5, 2021
29b7b12
Tuner interaction comment
Sefiraat Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/github/thebusybiscuit/sensibletoolbox/items/EnderTuner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public boolean hasGlow() {

@Override
public void onInteractItem(PlayerInteractEvent event) {
if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK) {
if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK) { // Make sure user is interacting intentionally (i.e. Not in a GUI)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Code and comments should never go on the same line
  2. The comment is a bit misleading, the PlayerInteractEvent is not called for GUI events anyway?

Copy link
Member Author

@Sefiraat Sefiraat Jul 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given all other onInteractItem methods from other items have a getAction check before without comment and you can see the issue it's resolving, shall I just remove the comment? I originally shipped without one as it seemed to just bring it in line with other items?

As for why this fires, im not sure if its just the SF Guide, but any GUI icon clicked makes the player interact with their item in hand - so this isn't specific to the endertuner on further inspection. Here is a clip from a server with SF only :
https://user-images.githubusercontent.com/20646323/124713615-b1224180-def8-11eb-9922-e15a7c5c306b.mp4

I had made the assumption that this behavior was normal and intended, if not, let me know and ill create an issue on the SF GitHub.

Regardless, we still only want the tuner to trigger if the player is using it in a natural manner so limiting to these action types is still wise I think?

Block clicked = event.getClickedBlock();
BaseSTBBlock stb = clicked == null ? null : SensibleToolbox.getBlockAt(clicked.getLocation(), true);

Expand Down