Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TinkerToolCraftingEvent #4953

Open
wants to merge 1 commit into
base: 1.18.2
Choose a base branch
from

Conversation

TT432
Copy link

@TT432 TT432 commented Jul 28, 2022

For the record, I am not a native English speaker.

I'm making a addon, I want add a Modifier to crafted tinker tools, but PlayerEvent.ItemCraftedEvent#crafting can't modify, so I write TinkerToolCraftingEvent.

@Insane96
Copy link

@KnightMiner
Copy link
Member

you cannot change default modifiers in a practical way, not without overwriting all the base tools individually

Can you please discuss your goal on discord? Need to decide if this really is the best approach, or if you would be better suited to a different hook (e.g. one called on tool rebuild to add new modifiers)

@KnightMiner KnightMiner added 1.18 Issue affects 1.18 Feature For pull requests adding in new content, and occasionally larger enhancements labels Jul 29, 2022
@TT432
Copy link
Author

TT432 commented Jul 29, 2022

you cannot change default modifiers in a practical way, not without overwriting all the base tools individually

Can you please discuss your goal on discord? Need to decide if this really is the best approach, or if you would be better suited to a different hook (e.g. one called on tool rebuild to add new modifiers)

I add new Origins's power, if player have this power, they crafted tool will be add new Modifier, I can't do it by recipe, unless directly replace the original recipe class

@KnightMiner
Copy link
Member

I have not forgotten about this PR, I just am not convinced a crafting event is the right way to do this, as there are many ways to get modifiers

My plan was to add a way to add "global tool traits" which will be applied like any of the modifiers from JSON on stat rebuild. Will leave this open until I implement such a thing, just cannot promise it will be 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.18 Issue affects 1.18 Feature For pull requests adding in new content, and occasionally larger enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants