Update extension to ensure successful build & distribution #4

jcfr · 2024-04-22T15:47:51Z

Update python scripts to use print function for python 3.x
Update icon and screenshot URLs to use https
Allow extension to build organizing module sources at the top-level
Fix discovery of ScoliosisMonitoring module reorganizing sub-packages
Fix loading of modules using current Qt5 QHeaderView API
Update CMake minimum required version based on Slicer 5.6

These issues were discovered in the context of the following work:

Switch extension index entry format from "s4ext" to "json" | ⚠️ Changes removed from main Slicer/Slicer#7629
CI: Transition from s4ext to json Slicer/ExtensionsIndex#2011

…evel

Fixes warnings like the following: ``` /path/to/ScoliosisMonitoring.py:2500: SyntaxWarning: "is not" with a literal. Did you mean "!="? ```

…ckages Prevent discovery of sub-packages as a regular module by introducing ScoliosisMonitoringLib.

lassoan

Thank you for the updates!

jcfr added 7 commits April 22, 2024 10:21

ENH: Update icon and screenshot URLs to use https

b7274f5

COMP: Allow extension to build organizing module sources at the top-l…

1b8c161

…evel

COMP: Update python scripts to use print function for python 3.x

d1d5652

COMP: Fix SyntaxWarning in ScoliosisMonitoring

74705f1

Fixes warnings like the following: ``` /path/to/ScoliosisMonitoring.py:2500: SyntaxWarning: "is not" with a literal. Did you mean "!="? ```

COMP: Fix discovery of ScoliosisMonitoring module reorganizing sub-pa…

a982ca0

…ckages Prevent discovery of sub-packages as a regular module by introducing ScoliosisMonitoringLib.

BUG: Fix loading of modules using current Qt5 QHeaderView API

0230acd

COMP: Update CMake minimum required version based on Slicer 5.6

c0d09c7

lassoan approved these changes Apr 23, 2024

View reviewed changes

lassoan merged commit e805100 into SlicerIGT:master Apr 23, 2024

jcfr deleted the fix-extension-build branch April 23, 2024 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update extension to ensure successful build & distribution #4

Update extension to ensure successful build & distribution #4

jcfr commented Apr 22, 2024 •

edited

Loading

lassoan left a comment

Update extension to ensure successful build & distribution #4

Update extension to ensure successful build & distribution #4

Conversation

jcfr commented Apr 22, 2024 • edited Loading

lassoan left a comment

Choose a reason for hiding this comment

jcfr commented Apr 22, 2024 •

edited

Loading