Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add 32 bit Tests For All Windows Targets #1393

Closed
wants to merge 8,624 commits into from
Closed

WIP: Add 32 bit Tests For All Windows Targets #1393

wants to merge 8,624 commits into from

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Expands the tests to 32bit on all Windows targets. #1386

JimBobSquarePants and others added 30 commits July 2, 2020 23:00
@JimBobSquarePants
Remove condition
d16a369
@JimBobSquarePants
Add coverlet workaround from docs
34b46ea
@JimBobSquarePants
Final cleanup
95104ba
@pekspro
Adds async and methods supporting paths in Bmp-ImageExtensions.
94a2d00
@pekspro
Adds async and methods supporting paths in Gif-ImageExtensions.
73d9820
@pekspro
Adds async and methods supporting paths in Jpeg-ImageExtensions.
1750c62
@pekspro
Adds async and methods supporting paths in Png-ImageExtensions.
9def344
@pekspro
Adds async and methods supporting paths in Tga-ImageExtensions.
4b402f4
@pekspro
Adds LoadAsync methods that accepting string path.
594b772
@pekspro
Adds unit test for LoadAsync(string path).
b85e455
@pekspro
Adds unit test for LoadAsync(Configuration configuration, string path…
61b41cd 
…, IImageDecoder decoder).
@pekspro
Adds DiscoverDecoderAsync.
a78af0e
@JimBobSquarePants
Merge pull request #1245 from SixLabors/js/gitversion-mainline
411919b 
Better Builds
@JimBobSquarePants
Merge branch 'master' into SaveAsExtensions
64e75ee
@JimBobSquarePants
Merge branch 'master' into LoadExtensions
a6a20be
@pekspro
Adds DiscoverDecoderAsync and starts using it.
399ac05
@pekspro
Adds unit test for LoadAsync(Configuration configuration, string path).
edb8bfc
@pekspro
Merge branch 'LoadExtensions' of https://github.com/pekspro/ImageSharp …
18c4a49 
…into LoadExtensions
@antonfirsov
Merge pull request #1257 from pekspro/LoadExtensions
3595574 
LoadAsync methods accepting string path.
@antonfirsov
Merge branch 'master' into SaveAsExtensions
87e7e8c
@JimBobSquarePants
Merge branch 'master' into DiscoverDecoderAsync
9edb4a0
@JimBobSquarePants
Merge pull request #1260 from pekspro/DiscoverDecoderAsync
979b9cd 
Async version of DiscoverDecoder
@JimBobSquarePants
Merge branch 'master' into SaveAsExtensions
4aff0de
@JimBobSquarePants
Update all dependency references.
343854f
@JimBobSquarePants
Try forcing binding redirects.
f8ef12d
@JimBobSquarePants
Merge branch 'master' into js/buffered-read
a810a67
@JimBobSquarePants
Handle slow streams. Fix #1268
4a28b91
@JimBobSquarePants
Restore missing Guard
3329b28
@JimBobSquarePants
More efficient reading
6102b2b
@JimBobSquarePants
Re-enable skipped tests
4c269f8
@JimBobSquarePants
Test FeatureSIMD
8a2117f
@JimBobSquarePants
Now test both disable values.
39809c5
@JimBobSquarePants
Split base disabled checks
d85f2e7
@JimBobSquarePants
Enable additional tests
cae5579
@JimBobSquarePants
Update PngEncoderTests.cs
fa87ce7
@JimBobSquarePants
Use envonment aware benchmarking for intrinsics.
436a4a7
@JimBobSquarePants
Use a single method for Block8x8F.TransposeInto.
68604da
@JimBobSquarePants
Enable all test platforms
01db316
@JimBobSquarePants
Remove method baseline property
0a3bff5
@JimBobSquarePants
Fix incorrect test on NET 32bit
3285cf3
@JimBobSquarePants
Merge pull request #1385 from SixLabors/js/feature-testing
3463609 
Advanced Feature Testing
@JimBobSquarePants
Optimize low hanging fruit and fix naming
f6b8adc
@JimBobSquarePants
Fix warning
1743ea9
@JimBobSquarePants
Disable NetNative optimization on UWP. Fix #1204
2a35860
@JimBobSquarePants
Merge pull request #1391 from SixLabors/js/fix-1204
6937405 
Fix ARM Build for UWP Release
@JimBobSquarePants
Merge branch 'master' into js/block8x8f-optimizations
f8d1a85
@JimBobSquarePants
Merge pull request #1390 from SixLabors/js/block8x8f-optimizations
53dd9b5 
Optimize Block8x8F low hanging fruit and fix naming
@JimBobSquarePants
Add 32 bit tests for all windows targets
f871dd9
@JimBobSquarePants
Copy link
Member Author

@antonfirsov This is kicking my ass. OutOfMemoryException's all over the place on NET Core 3.1 which is surprising given NET FX 4.7.2 doesn't have issues.

@antonfirsov
Copy link
Member

I would do a binary search between the current state vs. all memory intense test moved out of process. (Jpeg, Png, Bokeh, some other processors maybe.)

@antonfirsov
Copy link
Member

Gif!

@JimBobSquarePants
Copy link
Member Author

I'm gonna put this on hold. We cannot move tests out of process until #1376 is fixed upstream.

@JimBobSquarePants JimBobSquarePants marked this pull request as draft December 16, 2020 12:03
@JimBobSquarePants JimBobSquarePants changed the title Add 32 bit Tests For All Windows Targets WIP: Add 32 bit Tests For All Windows Targets Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:build unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JimBobSquarePants @antonfirsov @pekspro @wilka @brianpopow @Sergio0694 @rold2007 @dlemstra