Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IModFile for nested jars not marked as IModFile.Type.LIBRARY when compared to NeoForge's NestedLibraryModReader #1524

Open
MrCrayfish opened this issue Nov 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MrCrayfish
Copy link

MrCrayfish commented Nov 10, 2024

Minecraft version

1.20.1

Describe the bug

The creation of IModFile for nested jars (like Fabric API libraries) are not marked as a library.

Steps to reproduce

  1. Load Sinytra Connector with Forgified Fabric API
  2. Analyze ModFile#modFileType of any nested jar and it is not considered a library

Logs

No response

Additional context

The behavior seems to be inconsistent with NeoForge. NestedLibraryModReader from NeoForge treats all nested jars as a library and passes in IModFile.Type.LIBRARY in the IModFile#create method. This will help differentiate libraries from mods, and in mods like Catalogue, will be hidden in the mod list screen (if option is turned on).

Potentially offending lines:

IModFile modFile = IModFile.create(secureJar, JarModsDotTomlModFileReader::manifestParser);

IModFile modFile = IModFile.create(secureJar, f -> FabricModMetadataParser.createForgeMetadata(f, modPath.metadata().modMetadata(), modPath.metadata().visibleMixinConfigs(), modPath.metadata().generated()));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant