Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion to add an ability to hide apis and libraries like in modmenu #60

Open
delveticas opened this issue Sep 19, 2023 · 8 comments

Comments

@delveticas
Copy link

No description provided.

@Tapacywka
Copy link

Yes, please, we need this feature for our modpack, especially with Sinytra Connector where 100 additional libraries are presented.

@Boshigiri
Copy link

Yes, Sinytra Connector add lots of libraries.
We need this feature.

@MrCrayfish
Copy link
Owner

MrCrayfish commented Nov 10, 2024

@Boshigiri @Tapacywka Unfortunately a lot of authors don't mark their mod as a library in NeoForge (using FMLModType in the JAR manifest), so it's impossible for Catalogue to determine if a mod is actually a library. Nested jars should be marked as a library in NeoForge, however Sinytra might not be following the same behaviour.

@Boshigiri
Copy link

Because i tried the neoforge ported Modmenu(Better Modlist [(Neo)Forge]), it can hide the fabric api correctly, I thought it could be detected
So i should submit this issue to Sinytra Team?

@MrCrayfish
Copy link
Owner

I've just reported an issue outlining the problem (Sinytra/Connector#1524). I can mark Fabric API libraries correctly, but Jar in Jar libraries from regular Fabric mods won't be marked as libraries based on the code I've read in Sinytra Connector.

@MrCrayfish
Copy link
Owner

I've made a patch that will be available in 1.21.1
9902144

@Boshigiri
Copy link

Thank you for your work, just being able to hide the fabric api would be useful enough

@MrCrayfish
Copy link
Owner

I've also made it possible to hide libraries in the list, assuming they are also marked as libraries. Added in 1526557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants