Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(building/cpack_slides): Fix path for target include dir #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neumantm
Copy link
Contributor

@neumantm neumantm commented Dec 1, 2022

Description

Fix the path for the target include dir for the top level project.
For the top-level project the source dir is used.
This should usually not be suffixed with a includedir, as the headers are spread across the source subfolders.

Checklist

  • I made sure that the markdown files are formatted properly.
  • I made sure that all hyperlinks are working.

For the top-level project the source dir is used.
This should usually not be suffixed with a includedir,
as the headers are spread across the source subfolders.
@uekerman
Copy link
Member

uekerman commented Dec 2, 2022

Thanks for the activity. I must admit I do not yet understand your explanation. Could you sketch the hierarchy you have in mind?

@neumantm
Copy link
Contributor Author

neumantm commented Dec 5, 2022

Let's take the example from the exercise:

.
├── CMakeLists.txt
├── Dockerfile
├── fem
│   ├── fem.cpp
│   └── fem.hpp
├── filesystem
│   ├── filesystem.cpp
│   └── filesystem.hpp
├── flatset
│   ├── flatset.cpp
│   └── flatset.hpp
├── inittimezone
├── LICENSE
├── main.cpp
├── README.md

CMAKE_CURRENT_SOURCE_DIR would be . and headers must be included from . and not ./<somedir>.

@uekerman uekerman self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants