Skip to content

Commit

Permalink
updating the way app is signed
Browse files Browse the repository at this point in the history
  • Loading branch information
tibbi committed Apr 8, 2019
1 parent 8145a47 commit ee05326
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 26 deletions.
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
*.iml
*.aab
.gradle
/local.properties
/gradle.properties
/.idea/
.DS_Store
/build
/captures
release.keystore
signing.properties
keystore.jks
keystore.properties
30 changes: 10 additions & 20 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'

def keystorePropertiesFile = rootProject.file("keystore.properties")
def keystoreProperties = new Properties()
keystoreProperties.load(new FileInputStream(keystorePropertiesFile))

android {
compileSdkVersion 28
buildToolsVersion "28.0.3"
Expand All @@ -16,7 +20,12 @@ android {
}

signingConfigs {
release
release {
keyAlias keystoreProperties['keyAlias']
keyPassword keystoreProperties['keyPassword']
storeFile file(keystoreProperties['storeFile'])
storePassword keystoreProperties['storePassword']
}
}

buildTypes {
Expand Down Expand Up @@ -45,22 +54,3 @@ dependencies {
implementation 'com.squareup:otto:1.3.8'
implementation 'androidx.constraintlayout:constraintlayout:2.0.0-alpha3'
}

Properties props = new Properties()
def propFile = new File('signing.properties')
if (propFile.canRead()) {
props.load(new FileInputStream(propFile))

if (props != null && props.containsKey('STORE_FILE') && props.containsKey('KEY_ALIAS') && props.containsKey('PASSWORD')) {
android.signingConfigs.release.storeFile = file(props['STORE_FILE'])
android.signingConfigs.release.storePassword = props['PASSWORD']
android.signingConfigs.release.keyAlias = props['KEY_ALIAS']
android.signingConfigs.release.keyPassword = props['PASSWORD']
} else {
println 'signing.properties found but some entries are missing'
android.buildTypes.release.signingConfig = null
}
} else {
println 'signing.properties not found'
android.buildTypes.release.signingConfig = null
}
4 changes: 4 additions & 0 deletions keystore.properties_sample
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
storePassword=123456
keyPassword=abcdef
keyAlias=myAlias
storeFile=../keystore.jks
3 changes: 0 additions & 3 deletions signing.properties_sample

This file was deleted.

0 comments on commit ee05326

Please sign in to comment.