Implements SMF\Unicode\SpoofDectector #8202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects and prevents the use of Unicode character spoofing to cause mischief.
There are two main features of this PR:
Spoof detection in display names is always enabled. Spoof detection in the word censor is controlled by a new "Detect character spoofing when censoring" setting, which is enabled by default upon installing or upgrading.
To enable efficient checks for display names, a new column has been added to the members table that stores the "spoofdetector_name" of the member, which is a version of their display name that has been run through the "Confusable Detection" algorithm defined in UTS #39, section 4.
The SMF\Tasks\UpdateUnicode background task has been expanded to fetch updates to the official list of confusable characters and related files. It then compiles the confusables data into a PHP data file in SMF\Unicode\Confusables.php. Finally, it spawns a second task, SMF\Tasks\UpdateSpoofDetectorNames, which takes care of updating the "spoofdetector_name" for each member.