Report

[live627]

• The Report controller uses the new objects instead of raw SQL queries. Insert reference to Pinocchio saying "I'm a Real Boy now!"
• Add a new report type for board access. Well actually it was moved from the board report in an attempt to be more accessible.
• Use JavaScript to split long tables, increasing readability and eliminating the need to scroll vertically . Who wants to do that?

I also have some code that adds checkboxes to filter the results by category mainly useful for board permissions. Shall I add a commit for that?

[Sesquipedalian]

This line causes PHP to die with the following fatal error:

Fatal error: Uncaught TypeError: explode(): Argument #2 ($string) must be of type string, array given in /path/to/forum/Sources/Actions/Admin/Reports.php:303 Stack trace: #0 /path/to/forum/Sources/Actions/Admin/Reports.php(303): explode(',', Array) #1 [internal function]: SMF\Actions\Admin\Reports->boards() #2 /path/to/forum/Sources/Actions/Admin/Reports.php(194): call_user_func(Array) #3 /path/to/forum/Sources/Actions/Admin/Reports.php(642): SMF\Actions\Admin\Reports->execute() #4 [internal function]: SMF\Actions\Admin\Reports::call() #5 /path/to/forum/Sources/Actions/Admin/ACP.php(786): call_user_func(Array) #6 /path/to/forum/Sources/Actions/Admin/ACP.php(813): SMF\Actions\Admin\ACP->execute() #7 [internal function]: SMF\Actions\Admin\ACP::call() #8 /path/to/forum/Sources/Forum.php(263): call_user_func(Array) #9 /path/to/forum/index.php(146): SMF\Forum->execute() #10 {main} thrown in /path/to/forum/Sources/Actions/Admin/Reports.php on line 303

[live627]

fixed

[Sesquipedalian]

Delete?

[Sesquipedalian]

I also have some code that adds checkboxes to filter the results by category mainly useful for board permissions. Shall I add a commit for that?

Sounds nice. Yes, please!

[live627]

added those extra checkboxes

Outdated

[Sesquipedalian]

1. The Board Access report uses the wrong title in the cat_bars.
2. There is a useless duplicate table for each board in the Boards report.
   Perhaps some more work needs to go into the logic that breaks up wide tables?
3. The checkboxes don't do anything. I suggested changing <style> to <script> below, which is necessary. However, even after I did that in my own tests, the JavaScript ran into syntax errors that will need to be fixed.