Move a bunch of repeat functions to a trait #8161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good idea, but why move the interface and this new trait out of the SMF\Action namespace? |
|
I believe that namespace should only be for implementations.
…On Sun, Mar 31, 2024 at 6:32 PM Jon Stovell ***@***.***> wrote:
This is a good idea, but why move the interface and this new trait out of
the SMF\Action namespace?
—
Reply to this email directly, view it on GitHub
<#8161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN5CM72L5WZNIR32HEDY3C2KJAVCNFSM6AAAAABFP7WSRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGAYDMMZQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I tend to think that traits and interfaces should live where they're used, but I don't have strong feelings about this. And as I think about it, I suppose your preferred organization is in fact the way we already do it in the way SMF\Cache, SMF\Db, etc., relate their base classes and interfaces with the implementations in their *\API sub-namespaces. So okay, sure. |
|
Can I get you to resolve the conflicts in this PR, @live627? Then we can merge it. |
|
Sure, no problem.
…On Thu, Apr 25, 2024 at 6:37 PM Jon Stovell ***@***.***> wrote:
Can I get you to resolve the conflicts in this PR, @live627
<https://github.com/live627>? Then we can merge it.
—
Reply to this email directly, view it on GitHub
<#8161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNNYRTWNNJCI6CYU3NRLY7GVXDAVCNFSM6AAAAABFP7WSRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGQ3TOMRQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No need for constantly implementing the same `load()` and `call()` in every action, we have traits for that. Signed-off-by: John Rayes <[email protected]>
|
Done |
Sesquipedalian
requested changes
Apr 26, 2024
Sesquipedalian
approved these changes
Apr 29, 2024
|
I went ahead and fixed the documentation issues myself. Glad to have this PR merged. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for constantly implementing the same
load()andcall()in every action, we have traits for that.