Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP 1.1 Chunked transfer #7930

Merged

Conversation

jdarwood007
Copy link
Member

Fixes #7929

@Oldiesmann Test and confirm

@Oldiesmann
Copy link
Contributor

Something else seems to be broken with scheduled tasks now unfortunately. If I choose to run the task now, it says it was successful but the "next due" never changes and nothing is updated in the task log. I also have several tasks with "next due" dates in the past, and nothing has been updated in the task log in a while.

@jdarwood007
Copy link
Member Author

jdarwood007 commented Dec 4, 2023

I suspect there is another issue then. The data is updating correctly at least though? That is the focus on this PR, which is to correct the data not being handled properly due to chunking in HTTP 1.1.

I do get a error when I run it myself still, but its due to a missing Use statement. I fixed that in: https://github.com/SimpleMachines/SMF/pull/7927/files#diff-0110925af7e28153225ee796276bc6329a889f3631c500c05527ad06a756b223

@Oldiesmann
Copy link
Contributor

Tried it locally on my test board on Windows and it worked fine (your fix fixed the issue). Not sure why scheduled tasks aren't working on my server.

@Oldiesmann
Copy link
Contributor

Already mentioned this in Discord but will post here as well for anyone who didn't see that. The issue with tasks not getting run on my board was because the Tasks directory was never renamed. I deleted the "tasks" directory, uploaded the one from my local copy ("Tasks" with a capital T) and updated the path in Settings.php and everything is working now. The change in this PR also fixes the issue with the latest-news.js file.

@Sesquipedalian Sesquipedalian merged commit 0a2258d into SimpleMachines:release-3.0 Dec 4, 2023
3 checks passed
@jdarwood007 jdarwood007 deleted the socketChunkedFixed branch December 19, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest-news.js is butchered in SMF 3
3 participants