Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loads all categories in Category::getTree(), not just populated ones #7912

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Loads all categories in Category::getTree(), not just populated ones #7912

merged 2 commits into from
Nov 27, 2023

Conversation

Sesquipedalian
Copy link
Member

Fixes #7908

Also standardizes signatures for queryData() methods across various classes.

@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 1 milestone Nov 27, 2023
jdarwood007
jdarwood007 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@jdarwood007 jdarwood007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now

@jdarwood007 jdarwood007 merged commit 2f9077c into SimpleMachines:release-3.0 Nov 27, 2023
3 checks passed
@Sesquipedalian Sesquipedalian deleted the category_create branch November 27, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdarwood007 jdarwood007 jdarwood007 approved these changes

Assignees
No one assigned
Labels
Administrative Boards
Projects
None yet
Milestone
3.0 Alpha 1
Development

Successfully merging this pull request may close these issues.

Adding a category doesn't work in SMF 3
2 participants
@Sesquipedalian @jdarwood007