Fixes problem getting the number of search results #7910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
jdarwood007
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
That is what I was missing. Calling the current method to initiate the generator.
Works for me with no issue now. @Oldiesmann Can you also confirm?
|
No errors on my end either and it returned the expected result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7877
Since a generator doesn't start executing its code until the first time it is asked to do so, we had to call it at least once in order to cause SearchResult::$messages_request to be set. The easiest way to do that was just to call
self::$getter->current();in order to kick off the query.