Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objectification #7846

Closed
wants to merge 260 commits into from
Closed

Objectification #7846

wants to merge 260 commits into from

Conversation

Sesquipedalian
Copy link
Member

Refactors SMF to use the object oriented code paradigm.

@Sesquipedalian
Use SMF\ namespace for Likes class
f632e84 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Uses SMF\ namespace for Mentions class
3ca582f 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Uses SMF\Subscriptions namespace for paid subs
0d82e1c 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Defines constants and loads Settings.php in one place
b1036d3 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Forum
cb81383 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Migrates SMF\ProxyServer class to own file for autoloading
fd77758 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\TaskRunner
69c6cfb 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\ServerSideIncludes
701ed01 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Db\DatabaseApi and subclasses
d18f50c 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\BBCodeParser
f2f9518 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Migrates all cache functions to CacheApi
57ffdf7 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Migrates search API detection functions to SearchApi
21f3858 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\PackageManager subclasses
2cfbc83 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Standardizes our patterns for constructing and calling objects
350bb18 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Config and SMF\Utils
d3e1f9c 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Improves display of object oriented code in backtraces
904d9c6 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Lang
1c9d84a 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\User
49c915a 
This eliminates a whole bunch of redundant code and variables.

Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Gets rid of some unnecessary global variables
5addee6 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Renames Subs-Boards.php and Subs-Categories.php
9bf78d0 
Done in a separate commit to preserve history.
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Board
56dee0e 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Category
e9b5dc7 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Topic
3b3b4e0 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Renames Subs-Post.php to Msg.php
148b123 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Msg and SMF\Mail
320797a 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\BoardIndex
68d1f57 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\MessageIndex
6f6eaec 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Display
e713fac 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Theme
a025e7f 
With this commit, Sources/Load.php ceases to exist because everything it contained has been moved elsewhere.
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Renames Drafts.php to Draft.php
8974119 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves Subs-Timezones.php to TimeZone.php
b2f232a 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\TimeZone
93fb1f2 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Converts scheduled tasks to background tasks
b97d6f4 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\PageIndex
5840996 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves Likes.php to Actions/Like.php
ba81e29 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Cleans up SMF\Actions\Like
dc8ce28 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves prepareLikesContext() to Topic::getLikedMsgs()
74bc66d 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves several functions to SMF\Config
04ca802 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\Url
f555aa7 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\IP
d6ae097 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves all time-related functions to SMF\Time
12d505a 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves several exiting and server response functions to SMF\Utils
01f8e58 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves get_gravatar_url to SMF\User::getGravatarUrl
0bbad90 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves shorten_subject() to SMF\Utils::shorten()
8e4b113 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves text2words() to SMF\Utils::text2words()
5efd785 
Also adds SMF\Unicode\Utf8String::extractWords(), which does a much better job of finding words in non-ASCII strings than the old code did. There is still room for improvement, but that will have to wait until later.

Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves safe_serialize & safe_unserialize to SMF\Utils
e287520 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Renames SMF\Fetchers namespace to SMF\WebFetch
6188233 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\WebFetch\WebFetchApi and related classes
18f0441 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves smf_chmod() to SMF\Utils::makeWritable()
d0f8665 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves build_regex() to SMF\Utils::buildRegex()
3d0b242 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves cleanXml() and JavaScriptEscape() to SMF\Utils
3132dfe 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves a few miscellaneous string functions to SMF\Utils
4267141 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves is_filtered_request() to SMF\QueryString::isFilteredRequest()
5bf0338 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves get_mime_type() and check_mime_type() to SMF\Utils
b640edc 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves truncate_array() and array_length() to SMF\Utils
90f011b 
Also fixes truncate_array(), since it didn't actually work. Also removes useless $deep parameter.

Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Implements SMF\IntegrationHook
a8ee0d5 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Moves call_helper() to SMF\Utils::getCallable()
5f7dbdb 
Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Sends Subs.php into the long night
07664ce 
Like Load.php, Subs.php has been removed rather than turned into a backward compatibility stub file because every existing mod would assume that it had already been included and wouldn't try to include it themselves. The class_exists() calls in Subs-Compat.php are all we need to do now to maintain backward compatibility for those mods.

Signed-off-by: Jon Stovell <[email protected]>
@Sesquipedalian
Copy link
Member Author

Bleh. I chose the wrong target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sesquipedalian