Persistence layer interface #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaverik
reviewed
Nov 28, 2021
aneeshsharma
approved these changes
Dec 9, 2021
aneeshsharma
requested changes
Dec 9, 2021
aneeshsharma
reviewed
Dec 9, 2021
aneeshsharma
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the interface of persistence layer. We would have one mongo based implementation for now.
Writing the Mongo stuff behind an interface would help us support multiple data storage systems, say for example if we feel tomorrow that we need to migrate to DynamoDB or install inhouse for a client who wants to store data in PostgreSQL. Also this will help us easily mock out the DB layer for testing our business logic.